-
-
Notifications
You must be signed in to change notification settings - Fork 2
Enable Python 3.13, add setuptools dependency #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12263830459. Examine the logs at this URL for more detail. |
|
@dopplershift Here's a repro of the failure. The culprit is the pydub dependency which is incompatible with Python 3.13. |
|
See also jiaaro/pydub#815, jiaaro/pydub#816 |
|
The upstream repository for audiogrep was archived in favor of videogrep itself, so I'm not sure this update even makes much sense any more. I'll comment over on the videogrep PR on a path forward for that recipe. |
|
This will be unblocked by conda-forge/staged-recipes#28515 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14006643895. Examine the logs at this URL for more detail. |
|
@conda-forge/help-python Any idea why CI runs for OSX are cancelled before even starting? Errors are
|
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2025.03.21.21.56.39
|
audioop-lts seems to be broken on Mac OSX. Filed conda-forge/audioop-lts-feedstock#1 for @bmcfee. |
I'm afraid I have no idea how to debug this - I don't have access to an OSX machine, or any particular familiarity with compilation on that platform. Maybe someone else can step in to assist on this? Maybe @ocefpaf has some thoughts, having already been involved in the feedstock merge for this package a few weeks back. As an aside, since audiogrep is now deprecated in favor of videogrep, does it make sense to try shipping the package on 3.13 anyway? |
I'm not sure what is the problem with audiogrep, but the failure here is: Looks like it cannot imort |
Yes, I know 😀 I got that far, should have clarified. FWIW, this is from the audioop-feedstock as this package was removed from the standard library in 3.13. |
I suspect the problem here is that it should not have been a noarch package, and we need different binaries on osx and linux. Probably if windows was included in this test build, it would have failed as well. I'll get on that and see if we can fix it up. |
|
Right now I remember. Audioop is currently noarch because we did not want to allow it to be installed on python <=3.12, and removing noarch forces us to drop python version constraints. I have a side conversation with the dead-batteries maintainer about getting some more explicit guarantees on what happens with these packages if they are installed on older pythons, and I'd like to get that resolved before dropping noarch on audioop. (TLDR: it should be harmless, but it could be more clear how and why that's the case.) |
|
You could skip the package build on Python <= 3.12: build:
skip: true # [py < 313]and re-render. |
|
|
@bmcfee Thanks for investigating further! Sounds like we have no viable solution at this point then, do we? |
|
There is one other option to try, mentioned in the org pr thread on the audioop feedstock. I haven't had time to try it though. |
|
@bmcfee Did you have a chance to investigate this further? :) |
|
Sorry for falling off there - I did try the aforementioned thing here conda-forge/audioop-lts-feedstock#2 but couldn't get it working on all platforms. I haven't had time to come back to this yet, but any assistance would be appreciated. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)