Conversation
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
This looks good. We won’t merge right away though. Thank you!
Okay.Thank you so much for the review |
kathatherine
left a comment
kathatherine
left a comment
There was a problem hiding this comment.
Looks good, other than that one typo.
src/user/introduction.rst
Outdated
| -------------------- | ||
|
|
||
| Conda-forge is a community effort that provides conda packages for a wide range of software. | ||
| Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date ,compatible versions of conda packages along with all the required dependencies for the conda package manager. |
There was a problem hiding this comment.
This comma's out of place.
There was a problem hiding this comment.
Thank you for your review.I have fixed it.
src/user/introduction.rst
Outdated
| -------------------- | ||
|
|
||
| Conda-forge is a community effort that provides conda packages for a wide range of software. | ||
| Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date, compatible versions of conda packages along with all the required dependencies for the conda package manager. |
There was a problem hiding this comment.
How about noting that it is open source and driven by the community here? It sort of got taken out by the edit. How does this rough edit sound to you?
| Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date, compatible versions of conda packages along with all the required dependencies for the conda package manager. | |
| The conda-forge project can be viewed as a compilation of distributions, recipes, and build infrastructure that enable installing and distributing a wide range of software as conda packages. In a single channel, the conda-forge community provides up-to-date, compatible versions of conda packages along with all their required dependencies. Our work is driven by the community to provide packaged software free of charge and in a transparent manner. |
kathatherine
left a comment
kathatherine
left a comment
There was a problem hiding this comment.
This rewrite is very nice. Just one change needed!
src/user/introduction.rst
Outdated
| What is conda-forge? | ||
| -------------------- | ||
| Conda-forge can be defined as a compilation of distributions, recipes and build infrastructure that makes the task of installing conda packages hassle-free for a wide range of software. It is a single channel that provides all the up-to-date, compatible versions of conda packages along with all the required dependencies for the conda package manager. | ||
| The conda-forge project can be viewed as a compilation of distributions, recipes, and build infrastructure that enable installing and distributing a wide range of software as conda packages. In a single channel, the conda-forge community provides up-to-date, compatible versions of conda packages along with all their required dependencies. Our work is driven by the community to provide packaged software free of charge and in a transparent manner. |
There was a problem hiding this comment.
Should be "enables", since the subject of this phrase is "compilation".
There was a problem hiding this comment.
Could go either way ;) in the edit, I thought the "distributions, recipes, and build infrastructure" are the enabling ones
(but actually, I rephrased it precisely to avoid dealing with the stupid collective nouns, which I hate dealing with LOL :D https://www.britannica.com/dictionary/eb/qa/Collective-Nouns-and-Verb-Agreement)
There was a problem hiding this comment.
I get it, but the compilation of them is still doing the enabling. :)
I agree that collective nouns are the worst, though. Go ahead and change it, please, @shreya024.
kathatherine
left a comment
kathatherine
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me
jaimergp
left a comment
jaimergp
left a comment
There was a problem hiding this comment.
I like this but we'll have to discuss in a core call to ensure folks are alright with this messaging.
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 participants
Fixes: #1277
PR Checklist:
srcdirectory, not indocsor in the html files@beckermr