Open
Conversation
espy
commented
Jun 20, 2024
espy
commented
- Add more documentation for local development, testing, linting and formatting
Author
|
Sorry, opened this too soon, now it’s really open :) |
jaimergp
reviewed
Jun 25, 2024
Member
jaimergp
left a comment
jaimergp
left a comment
There was a problem hiding this comment.
Thanks! Just some minor changes about the text and what workflow we recommend.
Author
|
Thanks so much for the quick feedback, I’ve accepted your suggestions, will change the python version change command, remove the other bits and clean up the commit history. |
espy
force-pushed
the
docs/expand-developer-documentation
branch
from
7d46bf0 to
d4e5828
Compare
1 task
wolfv
reviewed
Jul 23, 2024
README.md
Outdated
| ----------------------- | ||
|
|
||
| To develop conda smithy, use your favortite conda-based environment manager and create an environment based on the `environment.yml`. | ||
| If you don’t already have a conda-based environment manager, install one. For example [Miniconda](https://docs.anaconda.com/free/miniconda/miniconda-install/). |
Member
There was a problem hiding this comment.
Can you refer to miniforge here? https://github.com/conda-forge/miniforge
Member
|
I added a comment to use the |
Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
hulkoba
force-pushed
the
docs/expand-developer-documentation
branch
from
f6dabce to
82d9584
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.