Open
Conversation
Author
|
Linting fails because of an unused var |
beckermr
requested changes
Aug 29, 2024
|
|
||
|
|
||
| class TestFeedstockIO(unittest.TestCase): | ||
| class TestFeedstockIO: |
Member
There was a problem hiding this comment.
Unit test executes the setup method before tests. If we simply remove the class inheritance here, I am not sure if that will happen or not given the code now. Can we convert the setup to a test fixture and the methods to functions?
| self.assertEqual(write_text, read_text) | ||
| assert write_text == read_text | ||
|
|
||
| def tearDown(self): |
Member
There was a problem hiding this comment.
The same comment applies to teardown. This should be part of a test fixture IIUIC.
|
|
||
|
|
||
| class TestLinter(unittest.TestCase): | ||
| class TestLinter: |
Member
There was a problem hiding this comment.
The methods on this class should be converted to pure functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋!
As part of the STF work for Conda, this PR introduces several improvements to our testing framework by transitioning from
unittesttopytestand leveragingpytest-mockfor mocking.It is split up from #1975.
Thank you!
Checklist