Add support for rattler-build-config#2309
Conversation
beckermr
left a comment
There was a problem hiding this comment.
Why are we forcing users to use a new thing in order to specify channels etc?
Rattler should be reading the variant config keys.
I don't like this change at all.
|
Also this configuration will not work with the ci-setup package and how it handles channels. |
|
my main idea was to reuse pixi-config for mirror + s3 configuration and package-format. channels were a natural addition since they are also in the pixi config crate. but i can also adjust the behavior and read them from the variant config instead |
|
I think this might be orthogonal. Yes, But just like While I think it's OK to read the configuration for channels from the variant config, I am not sure in how far the "variant config" is the "only" config for conda build tools. |
|
Ah yes. That makes sense. We need to redirect this pr to the ci-setup package. This is where we handle conda build options. |
|
@wolfv @pavelzw We set items in the condarc on the fly via the ci-setup package here: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/main/recipe/conda_forge_ci_setup/build_utils.py. Items go into the ci-setup package when they can be done without rerenders. I am guessing for the rattler build settings this is true. So we should have a similar mechanism for rattler build that reads settings out of the conda-forge.yml and applies them properly during the build. |
|
|
Checklist
newsentrypython conda_smithy/schema.py)closes #2226 (only the channel part, not priority), xref prefix-dev/rattler-build#1563, prefix-dev/rattler-build#1593