Skip to content

enable dev mode on azure-pipelines-win to support source contains symlink#2321

Open
trim21 wants to merge 5 commits intoconda-forge:mainfrom
trim21:patch-1
Open

enable dev mode on azure-pipelines-win to support source contains symlink#2321
trim21 wants to merge 5 commits intoconda-forge:mainfrom
trim21:patch-1

Conversation

@trim21
Copy link

@trim21 trim21 commented May 19, 2025

Checklist

  • Added a news entry
  • Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

more details: conda-forge/mediainfo-feedstock#5

also cc @wolfv

@trim21 trim21 requested a review from a team as a code owner May 19, 2025 11:00
@trim21 trim21 changed the title enable dev mode on azure-pipelines-win to support symlink enable dev mode on azure-pipelines-win to support source tarball contains symlink May 19, 2025
@trim21 trim21 changed the title enable dev mode on azure-pipelines-win to support source tarball contains symlink enable dev mode on azure-pipelines-win to support source contains symlink May 19, 2025
@wolfv
Copy link
Member

wolfv commented May 19, 2025

@jaimergp do you know if our content checks catch symlinks in packages on Windows? I think that should be disallowed for maximum compatibility.

@h-vetinari
Copy link
Member

more details: conda-forge/mediainfo-feedstock#5

A reference is not a suitable argument - please don't make reviewers chase down rabbitholes; at least provide a short summary.

In general I would be against enabling symlinks simply because that makes it much more likely that we accidentally publish a package with symlinks, which would be broken on a large portion of windows clients. But given that the checkout in conda-forge/mediainfo-feedstock#5 fails because the sources contain a symlink, I can at least see the argument.

[do] content checks catch symlinks in packages on Windows? I think that should be disallowed for maximum compatibility.

This would of course be a solution. Assuming that they don't already check for symlinks, what I'd prefer to avoid is that this gets pushed off as unrelated here, and then never happens.

@trim21
Copy link
Author

trim21 commented May 19, 2025

A reference is not a suitable argument - please don't make reviewers chase down rabbitholes; at least provide a short summary.

The title contains all the infomation I think, the link to that PR is just for the context.

@h-vetinari
Copy link
Member

the title is the what, not the why

@trim21
Copy link
Author

trim21 commented May 19, 2025

If we postpone this, is there an alternative solution I can put in place?

@trim21
Copy link
Author

trim21 commented May 19, 2025

A workaround would be checkout git repo in build scripts.....

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this might prevent checks about symlinks in conda packages right?

@trim21
Copy link
Author

trim21 commented May 31, 2025

Adding this might prevent checks about symlinks in conda packages right?

Looks like we currently don't have symlinks checks for windows in conda-forge or rattler.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants