enable dev mode on azure-pipelines-win to support source contains symlink#2321
enable dev mode on azure-pipelines-win to support source contains symlink#2321trim21 wants to merge 5 commits intoconda-forge:mainfrom
Conversation
|
@jaimergp do you know if our content checks catch symlinks in packages on Windows? I think that should be disallowed for maximum compatibility. |
A reference is not a suitable argument - please don't make reviewers chase down rabbitholes; at least provide a short summary. In general I would be against enabling symlinks simply because that makes it much more likely that we accidentally publish a package with symlinks, which would be broken on a large portion of windows clients. But given that the checkout in conda-forge/mediainfo-feedstock#5 fails because the sources contain a symlink, I can at least see the argument.
This would of course be a solution. Assuming that they don't already check for symlinks, what I'd prefer to avoid is that this gets pushed off as unrelated here, and then never happens. |
The title contains all the infomation I think, the link to that PR is just for the context. |
|
the title is the what, not the why |
|
If we postpone this, is there an alternative solution I can put in place? |
|
A workaround would be checkout git repo in build scripts..... |
isuruf
left a comment
There was a problem hiding this comment.
Adding this might prevent checks about symlinks in conda packages right?
Looks like we currently don't have symlinks checks for windows in conda-forge or rattler.build |
Checklist
newsentrypython conda_smithy/schema.py)more details: conda-forge/mediainfo-feedstock#5
also cc @wolfv