Skip to content

Fix macos self hosted labels#2326

Open
wolfv wants to merge 3 commits intoconda-forge:mainfrom
wolfv:fix-macos-self-hosted-labels
Open

Fix macos self hosted labels#2326
wolfv wants to merge 3 commits intoconda-forge:mainfrom
wolfv:fix-macos-self-hosted-labels

Conversation

@wolfv
Copy link
Member

@wolfv wolfv commented May 31, 2025

cc @aktech

@wolfv wolfv requested a review from a team as a code owner May 31, 2025 05:50
@wolfv
Copy link
Member Author

wolfv commented May 31, 2025

@aktech there is also this code that always adds "self-hosted" as a label. Should we keep it?

    self_hosted_default = list(
        runs_on[data["build_platform"]]["self_hosted_labels"]
    )
    self_hosted_default += ["self-hosted"]

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct AFAIK. cirun might be overriding defaults.

See for eg: https://github.com/guyrt/arrow/blob/master/dev/tasks/python-wheels/github.osx.arm64.yml#L44

@aktech
Copy link
Contributor

aktech commented May 31, 2025

@aktech there is also this code that always adds "self-hosted" as a label. Should we keep it?

Nope, that isn't required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants