Skip to content

Rebuild for PyPy3.7 for windows#68

Merged
ocefpaf merged 2 commits intoconda-forge:masterfrom
regro-cf-autotick-bot:rebuild-pypy37-windows-0-1_h53481f
Aug 5, 2021
Merged

Rebuild for PyPy3.7 for windows#68
ocefpaf merged 2 commits intoconda-forge:masterfrom
regro-cf-autotick-bot:rebuild-pypy37-windows-0-1_h53481f

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

This PR has been triggered in an effort to update pypy37-windows.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1001485670, please use this URL for debugging

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Copy Markdown

mattip commented Jul 12, 2021

The build is failing on a check for OpenSSL version, it seems somehow cryptography is picking up an older version somewhere.

===== testing package: cryptography-3.4.7-py37h7675efb_0 =====
running run_test.py
Version used by cryptography:
OpenSSL 1.1.1j  16 Feb 2021
Version in conda environment:
OpenSSL 1.1.1k  25 Mar 2021
Traceback (most recent call last):
  File "D:\bld\cryptography_1625500056165\test_tmp\run_test.py", line 23, in <module>
    assert linked_version == env_version
AssertionError

@h-vetinari
Copy link
Copy Markdown
Member

h-vetinari commented Jul 22, 2021

I remember windows doing weird things to prefer c:/system over pretty much everything. Ray Donnelly had introduced CONDA_DLL_SEARCH_MODIFICATION_ENABLE, which is used in the CPython builds. There's some relevant code for this probably in the cpython patches (as well as conda itself, obviously).

Some discussion can be found in this PR, conda-forge/staged-recipes#11452, as well as its ancestor conda-forge/openssl-feedstock#56

@mattip
Copy link
Copy Markdown

mattip commented Jul 22, 2021

It seems this patch is the one that adds CondaEcosystemModifyDllSearchPath_Init(), which checks if CONDA_DLL_SEARCH_MODIFICATION_ENABLE is in the environment and if so sets a different Dll search path. This new function in turn is called by the main entry point pymain_main. So I guess I should try to port that patch to PyPy.

It seems there are more patches that might be worth porting to PyPy.

@mattip
Copy link
Copy Markdown

mattip commented Aug 1, 2021

@conda-forge-admin, please restart ci

@mattip
Copy link
Copy Markdown

mattip commented Aug 1, 2021

The migration target PyPy 3.7 for windows passed.

ppc64le failed after tests when doing resource summary with

Validating outputs

Cloning into '/tmp/tmpb1dza552_recipe/feedstock-outputs'...

fatal: unable to access 'https://github.com/conda-forge/feedstock-outputs.git/': OpenSSL SSL_connect: Connection reset by peer in connection to github.com:443 

As that is not a target for this PR, I think this is ready for review

@h-vetinari
Copy link
Copy Markdown
Member

@conda-forge/cryptography anyone want to press the button?

@ocefpaf ocefpaf merged commit 997037d into conda-forge:master Aug 5, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-pypy37-windows-0-1_h53481f branch August 6, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants