-
-
Notifications
You must be signed in to change notification settings - Fork 9
Rebuild for pytorch 2.8 #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for pytorch 2.8 #41
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…5.10.05.00.13.54 Other tools: - conda-build 25.7.0 - rattler-build 0.47.0 - rattler-build-conda-compat 1.4.6
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/recipe.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18266334075. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
The Looks like conda-forge/pytorch-cpu-feedstock#422. |
|
I wasn't aware that multi-output recipes were supported by any implementation of the v1 recipe. Does it build correctly without the |
From https://github.com/search?type=code&q=org%3Aconda-forge+path%3Arecipe%2Frecipe.yaml+outputs&p=2, I see about 100+ feedstocks that seem to be using multi-output recipes already, so it should be supported? Doesn't seem to be experimental either, I see the docs are under https://rattler.build/latest/reference/recipe_file/#outputs-section and not in the experimental features page. |
|
https://rattler.build/latest/reference/recipe_file/#outputs-section:
My interpretation is that you cannot build one package and split it which is what we were doing here. You can only build a package and then create some meta packages or build secondary packages separately. "cache for multiple outputs" is the feature that is closest to what we were doing with the v0 recipe. |
Ah I totally missed that, now it makes sense why there was a top-level I'll revert back to v0 then, but will do this after conda-forge/pytorch-cpu-feedstock#422 is resolved. |
This reverts commit 9a8aaac.
…5.10.13.17.18.10 Other tools: - conda-build 25.7.0 - rattler-build 0.47.0 - rattler-build-conda-compat 1.4.6
This PR has been triggered in an effort to update pytorch28.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/18234956514 - please use this URL for debugging.