Skip to content

Consider for 1.11 -- Use cmake to install cmake configuration files #40

Open
conda-forge-admin wants to merge 4 commits intoconda-forge:mainfrom
conda-forge-admin:conda_forge_admin_39
Open

Consider for 1.11 -- Use cmake to install cmake configuration files #40
conda-forge-admin wants to merge 4 commits intoconda-forge:mainfrom
conda-forge-admin:conda_forge_admin_39

Conversation

@conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Aug 17, 2025

I (hmaarrfk) would like to use cmake so that the cmake configuration files get installed on unix so that they can be used by downstream projects.

c-blosc2 rerenctly switched to using the upstream (lz4) cmake files, and now lz4 can't be found since we don't ship them on unix.
https://github.com/Blosc/c-blosc2/pull/682/files#diff-f993a15b91fcd339e787b759d41d15f18dfeb0333ba451079a9d035462296ec0

I understand that there can be some ABI risks, so happy to wait for the next minor release.

@conda-forge-admin
Copy link
Contributor Author

conda-forge-admin commented Aug 17, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17027351512. Examine the logs at this URL for more detail.

@conda-forge-admin conda-forge-admin marked this pull request as ready for review August 17, 2025 22:10
@hmaarrfk hmaarrfk marked this pull request as draft August 17, 2025 23:30
@hmaarrfk hmaarrfk changed the title MNT: rerender Use cmake to install cmake configuration files Aug 17, 2025
@hmaarrfk hmaarrfk force-pushed the conda_forge_admin_39 branch from e96e80d to 1f42dc2 Compare August 17, 2025 23:33
@hmaarrfk hmaarrfk changed the title Use cmake to install cmake configuration files Consider for 1.11 -- Use cmake to install cmake configuration files Aug 17, 2025
@hmaarrfk
Copy link
Contributor

Thanks all for considering! This seems to pass local building on linux. fingers crossed for other platforms

@hmaarrfk hmaarrfk marked this pull request as ready for review September 6, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants