Consider for 1.11 -- Use cmake to install cmake configuration files #40
Open
conda-forge-admin wants to merge 4 commits intoconda-forge:mainfrom
Open
Consider for 1.11 -- Use cmake to install cmake configuration files #40conda-forge-admin wants to merge 4 commits intoconda-forge:mainfrom
conda-forge-admin wants to merge 4 commits intoconda-forge:mainfrom
Conversation
Contributor
Author
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17027351512. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.08.17.21.16.27
e96e80d to
1f42dc2
Compare
Contributor
|
Thanks all for considering! This seems to pass local building on linux. fingers crossed for other platforms |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I (hmaarrfk) would like to use cmake so that the cmake configuration files get installed on unix so that they can be used by downstream projects.
c-blosc2 rerenctly switched to using the upstream (lz4) cmake files, and now lz4 can't be found since we don't ship them on unix.
https://github.com/Blosc/c-blosc2/pull/682/files#diff-f993a15b91fcd339e787b759d41d15f18dfeb0333ba451079a9d035462296ec0
I understand that there can be some ABI risks, so happy to wait for the next minor release.