-
-
Notifications
You must be signed in to change notification settings - Fork 22
Update maintainers #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi @khallock could you please help me update the maintainers list for this repo? |
…a-forge-pinning 2021.08.14.10.30.44
recipe/meta.yaml
Outdated
|
|
||
| build: | ||
| number: 23 | ||
| number: 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to bump the recipe build number for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the bumping.
|
@erogluorhan I'm assuming you are substituting @khallock, right? Do you want to try to fix the recipe or do you want me to merge this so you can iterate later in another PR? |
I also kept @khallock in the maintainers, so I am not substituting. If @khallock wants to be removed, then we can do that. Let me first spend some time working to fix this recipe before you merge it. I will let you know. |
|
@erogluorhan, are you still wanting to be added as a maintainer? If so, we can make a fresh PR for that. |
Thanks for asking! Yes, please do so (even though I couldn't manage some of my time to be put here recently) |
|
closing this via #116 |
|
Cheers @erogluorhan, great to have you on board! Do you think you might have time to look at NCAR/ncl#173 for a future release of NCL? |
Yes, for a future release, but I don't think it could be sooner (say in these few months). |
|
@erogluorhan, I understand that it will be some time until a new release. I would encourage you to have a look at the patch in the near future. It is really rather small and longstanding PRs tend to get more difficult to integrate. In any case, let's take any further discussion over to NCAR/ncl#173. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)