Skip to content

Conversation

@erogluorhan
Copy link

@erogluorhan erogluorhan commented Aug 16, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@erogluorhan
Copy link
Author

@conda-forge-admin, please rerender

@erogluorhan
Copy link
Author

Hi @khallock could you please help me update the maintainers list for this repo?

recipe/meta.yaml Outdated

build:
number: 23
number: 24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump the recipe build number for this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the bumping.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 16, 2021

@erogluorhan I'm assuming you are substituting @khallock, right? Do you want to try to fix the recipe or do you want me to merge this so you can iterate later in another PR?

@erogluorhan
Copy link
Author

@erogluorhan I'm assuming you are substituting @khallock, right? Do you want to try to fix the recipe or do you want me to merge this so you can iterate later in another PR?

I also kept @khallock in the maintainers, so I am not substituting. If @khallock wants to be removed, then we can do that.

Let me first spend some time working to fix this recipe before you merge it. I will let you know.

@xylar
Copy link
Contributor

xylar commented Sep 29, 2021

@erogluorhan, are you still wanting to be added as a maintainer? If so, we can make a fresh PR for that.

@erogluorhan
Copy link
Author

@erogluorhan, are you still wanting to be added as a maintainer? If so, we can make a fresh PR for that.

Thanks for asking! Yes, please do so (even though I couldn't manage some of my time to be put here recently)

@xylar
Copy link
Contributor

xylar commented Sep 29, 2021

closing this via #116

@xylar xylar closed this Sep 29, 2021
@zklaus
Copy link
Contributor

zklaus commented Sep 30, 2021

Cheers @erogluorhan, great to have you on board! Do you think you might have time to look at NCAR/ncl#173 for a future release of NCL?

@erogluorhan
Copy link
Author

Cheers @erogluorhan, great to have you on board! Do you think you might have time to look at NCAR/ncl#173 for a future release of NCL?

Yes, for a future release, but I don't think it could be sooner (say in these few months).

@zklaus
Copy link
Contributor

zklaus commented Oct 1, 2021

@erogluorhan, I understand that it will be some time until a new release. I would encourage you to have a look at the patch in the near future. It is really rather small and longstanding PRs tend to get more difficult to integrate. In any case, let's take any further discussion over to NCAR/ncl#173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants