-
-
Notifications
You must be signed in to change notification settings - Fork 39
Add activation script to check for system-libs that override openssl install #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
h-vetinari
wants to merge
6
commits into
conda-forge:main
Choose a base branch
from
h-vetinari:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
50de15e
re-enable a previously broken test that was fixed upstream
h-vetinari ddabaea
add check for system-libs in activation script
h-vetinari c548d99
bump build number
h-vetinari dee17f2
MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.6.17, and co…
af73fe6
fix missing variables
h-vetinari 7ae83af
add check for system-libs in activation script also for bash-on-win
h-vetinari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| :: Check whether there are dlls for openssl on the system path that would gets | ||
| :: picked up by the windows loader before those in the conda environment. | ||
| :: If yes, warn that the environment is potentially vulnerable. | ||
|
|
||
| @echo off | ||
|
|
||
| set "LIBSSL_PATH=C:\Windows\System32\libssl-1_1-x64.dll" | ||
| set "LIBCRYPTO_PATH=C:\Windows\System32\libcrypto-1_1-x64.dll" | ||
|
|
||
| set "HAS_SYS_LIBS=F" | ||
| set "HAS_SYS_SSL=F" | ||
| set "HAS_SYS_CRYPTO=F" | ||
| if exist %LIBSSL_PATH% ( | ||
| set "HAS_SYS_LIBS=T" | ||
| set "HAS_SYS_SSL=T" | ||
| ) | ||
| if exist %LIBCRYPTO_PATH% ( | ||
| set "HAS_SYS_LIBS=T" | ||
| set "HAS_SYS_CRYPTO=T" | ||
| ) | ||
|
|
||
| :: The carets are used for escaping brackets, which would otherwise be interpreted (and fail). | ||
| if "%HAS_SYS_LIBS%"=="T" ( | ||
| ECHO WARNING: Your system contains ^(potentially^) outdated libraries under: | ||
| if "%HAS_SYS_SSL%"=="T" ECHO WARNING: %LIBSSL_PATH% | ||
| if "%HAS_SYS_CRYPTO%"=="T" ECHO WARNING: %LIBCRYPTO_PATH% | ||
| ECHO WARNING: These libraries will be linked before those in the conda | ||
| ECHO WARNING: environment and might make your installation vulnerable! | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Check whether there are dlls for openssl on the system path that would gets | ||
| # picked up by the windows loader before those in the conda environment. | ||
| # If yes, warn that the environment is potentially vulnerable. | ||
|
|
||
| LIBSSL_PATH=/c/Windows/System32/libssl-1_1-x64.dll | ||
| LIBCRYPTO_PATH=/c/Windows/System32/libcrypto-1_1-x64.dll | ||
|
|
||
| HAS_SYS_LIBS=F | ||
| HAS_SYS_SSL=F | ||
| HAS_SYS_CRYPTO=F | ||
| if [ -f "$LIBSSL_PATH" ]; then | ||
| HAS_SYS_LIBS=T | ||
| HAS_SYS_SSL=T | ||
| fi | ||
| if [ -f "$LIBCRYPTO_PATH" ]; then | ||
| HAS_SYS_LIBS=T | ||
| HAS_SYS_CRYPTO=T | ||
| fi | ||
|
|
||
| # The carets are used for escaping brackets, which would otherwise be interpreted (and fail). | ||
| if [ $HAS_SYS_LIBS == "T" ]; then | ||
| echo "WARNING: Your system contains (potentially) outdated libraries under:" | ||
| if [ $HAS_SYS_SSL == "T" ]; then echo "WARNING: $LIBSSL_PATH"; fi | ||
| if [ $HAS_SYS_CRYPTO == "T" ]; then echo "WARNING: $LIBCRYPTO_PATH"; fi | ||
| echo "WARNING: These libraries will be linked before those in the conda" | ||
| echo "WARNING: environment and might make your installation vulnerable!" | ||
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.