Merged
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Contributor
|
Failure on aarch64: |
Contributor
Upstream issue: PixarAnimationStudios/OpenUSD#3711 . |
Contributor
|
I think it is just new code that was added in PixarAnimationStudios/OpenUSD@4b58126 and enabled by default in PixarAnimationStudios/OpenUSD@5fdfda1 . I think it was simply never build on linux aarch64, probably just adding an ifdef to only compile the asm snippet on x86 would fix the problem, done in PixarAnimationStudios/OpenUSD#3764 . |
Contributor
|
fyi @oursland you seem to be using openusd, so feel free to check this out. |
Contributor
|
A bunch of test failures in macOS: basically are all cases in which Python libraries are not linked to the tests as intended. We can either explicitly link the tests to the Python library, or just skip them. |
Contributor
|
On Windows, a test is failing: |
Contributor
|
@conda-forge-admin please rerender |
Contributor
Apparently the test is removed even by upstream CI as it exhaust the memory of the CI runner, see PixarAnimationStudios/OpenUSD@e80e8e1 . So I think it is safe to just skip it. |
Contributor
|
@conda-forge-admin please rerender |
Contributor
|
@conda-forge-admin please rerender |
Contributor
|
On macOS, there are a bunch of: those are similar to conda-forge/opencv-feedstock#493, so we can use the same solution. |
Contributor
|
@conda-forge-admin please rerender |
Add Python linking for OpenUSD binaries to handle transitive dependencies.
Contributor
|
@conda-forge-admin please rerender |
traversaro
approved these changes
Nov 29, 2025
Contributor
|
On Windows, we forgot to exclude the On macOS, ~14 test fail: almost all with the same error: I thought to fix this with f083568. but apparently it was not useful. |
Disable additional test 'testExecGeomXformable_Perf_Large' due to upstream issues and update the ctest command accordingly.
Contributor
|
Ok, on that apparently we already detected in #16 (comment) . |
Contributor
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
Add workaround for Rattler build issue on macOS.
Update the MANIFEST variable to use SRC_DIR if set.
Contributor
|
Ok, a few more failures. On macOS, the test fail with: the rpath workaround is affecting also test plugins, that in this case require the rpath to be set as the build system set. Probably we can modify the script to change the rpath after running the tests. Instead on Windows the failure is: Similar to conda-forge/numpy-feedstock#364 and RoboStack/ros-noetic#557 (comment) . |
Contributor
The offending file is: # - Configuration file for the pxr project
# Defines the following variables:
# PXR_MAJOR_VERSION - Major version number.
# PXR_MINOR_VERSION - Minor version number.
# PXR_PATCH_VERSION - Patch version number.
# PXR_VERSION - Complete pxr version string.
# PXR_INCLUDE_DIRS - Root include directory for the installed project.
# PXR_LIBRARIES - List of all libraries, by target name.
# PXR_foo_LIBRARY - Absolute path to individual libraries.
# The preprocessor definition PXR_STATIC will be defined if appropriate
get_filename_component(PXR_CMAKE_DIR "${CMAKE_CURRENT_LIST_FILE}" PATH)
set(PXR_MAJOR_VERSION "0")
set(PXR_MINOR_VERSION "25")
set(PXR_PATCH_VERSION "8")
set(PXR_VERSION "2508")
include(CMakeFindDependencyMacro)
# If Python support was enabled for this USD build, find the import
# targets by invoking the appropriate FindPython module. Use the same
# LIBRARY and INCLUDE_DIR settings from the original build if they
# were set. This can be overridden by specifying different values when
# running cmake.
if(ON)
if (NOT DEFINED Python3_EXECUTABLE)
if (NOT [[D:\src\openusd-feedstock\output\bld\rattler-build_openusd\h_env\python.exe]] STREQUAL "")
set(Python3_EXECUTABLE [[D:\src\openusd-feedstock\output\bld\rattler-build_openusd\h_env\python.exe]])
endif()
endif()
if (NOT DEFINED Python3_LIBRARY)
if (NOT [[]] STREQUAL "")
set(Python3_LIBRARY [[]])
endif()
endif()
if (NOT DEFINED Python3_INCLUDE_DIR)
if (NOT [[]] STREQUAL "")
set(Python3_INCLUDE_DIR [[]])
endif()
endif()
if (NOT DEFINED Python3_VERSION)
find_dependency(Python3 "3.12" EXACT COMPONENTS Development)
else()
find_dependency(Python3 COMPONENTS Development)
endif()
endif()
if (NOT DEFINED PXR_FIND_TBB_IN_CONFIG)
set(PXR_FIND_TBB_IN_CONFIG "ON")
endif()
if (PXR_FIND_TBB_IN_CONFIG)
find_dependency(TBB 2021.13.0 CONFIG)
else()
add_library(TBB::tbb SHARED IMPORTED)
macro(_add_property name value)
if (NOT "${value}" STREQUAL "")
set_target_properties(TBB::tbb PROPERTIES ${name} "${value}")
endif()
endmacro()
_add_property(INTERFACE_INCLUDE_DIRECTORIES "D:/src/openusd-feedstock/output/bld/rattler-build_openusd/h_env/Library/include")
_add_property(INTERFACE_COMPILE_DEFINITIONS "$<$<CONFIG:DEBUG>:TBB_USE_DEBUG>")
_add_property(INTERFACE_LINK_DIRECTORIES "")
_add_property(IMPORTED_IMPLIB "")
_add_property(IMPORTED_LOCATION "")
endif()
if (NOT DEFINED PXR_FIND_OPENSUBDIV_IN_CONFIG)
set(PXR_FIND_OPENSUBDIV_IN_CONFIG "ON")
endif()
if (PXR_FIND_OPENSUBDIV_IN_CONFIG)
find_dependency(OpenSubdiv 3.6.1 CONFIG)
endif()
# If MaterialX support was enabled for this USD build, try to find the
# associated import targets by invoking the same FindMaterialX.cmake
# module that was used for that build. This can be overridden by
# specifying a different MaterialX_DIR when running cmake.
if(OFF)
if (NOT DEFINED MaterialX_DIR)
if (NOT [[]] STREQUAL "")
set(MaterialX_DIR [[]])
endif()
endif()
find_dependency(MaterialX)
endif()
# Similar to MaterialX above, we are using Imath's cmake package config, so set
# the Imath_DIR accordingly to find the associated import targets which were
# used for this USD build.
# Note that we only need to do this, when it is determined by Imath is being
# used instead of OpenExr (refer Packages.cmake)
if()
if (NOT DEFINED Imath_DIR)
if (NOT [[]] STREQUAL "")
set(Imath_DIR [[]])
endif()
endif()
find_dependency(Imath)
endif()
# If this build is using a custom work implementation, find the package
# providing that implementation.
if(NOT "" STREQUAL "")
if (NOT DEFINED )
if (NOT [[]] STREQUAL "")
set( [[]])
endif()
endif()
find_dependency()
endif()
include("${PXR_CMAKE_DIR}/cmake/pxrTargets.cmake")
if (TARGET usd_ms)
set(libs "usd_ms")
else()
set(libs "boost;python;arch;tf;gf;pegtl;js;trace;work;plug;vt;ts;ar;kind;sdf;sdr;pcp;usd;usdGeom;usdVol;usdMedia;usdShade;usdLux;usdProc;usdRender;usdHydra;usdRi;usdSemantics;usdSkel;usdUI;usdUtils;usdPhysics;vdf;ef;esf;esfUsd;exec;execUsd;execGeom;usdValidation;usdGeomValidators;usdPhysicsValidators;usdShadeValidators;usdSkelValidators;usdUtilsValidators;garch;hf;hio;cameraUtil;pxOsd;geomUtil;glf;hgi;hgiGL;hgiInterop;hd;hdar;hdGp;hdsi;hdSt;hdx;usdImaging;usdImagingGL;usdProcImaging;usdRiPxrImaging;usdSkelImaging;usdVolImaging;usdAppUtils;usdviewq")
endif()
set(PXR_LIBRARIES "")
set(PXR_INCLUDE_DIRS "${PXR_CMAKE_DIR}/include")
string(REPLACE " " ";" libs "${libs}")
foreach(lib ${libs})
get_target_property(location ${lib} LOCATION)
set(PXR_${lib}_LIBRARY ${location})
list(APPEND PXR_LIBRARIES ${lib})
endforeach()
if(NOT ON)
if(WIN32)
list(APPEND PXR_LIBRARIES Shlwapi.lib)
list(APPEND PXR_LIBRARIES Dbghelp.lib)
endif()
add_definitions(-DPXR_STATIC)
endif()the hardcodec prefixes are already ignored by the CMake logic, so probably we can just path that logic out to avoid problems. |
Contributor
|
@conda-forge-admin please rerender |
Contributor
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19819847395. Examine the logs at this URL for more detail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/16661321481 - please use this URL for debugging.