Skip to content

Rebuild for libabseil 20250127, libgrpc 1.71 & libprotobuf 5.29.3#204

Open
regro-cf-autotick-bot wants to merge 9 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:rebuild-absl_grpc_proto-0-1_h603bdb
Open

Rebuild for libabseil 20250127, libgrpc 1.71 & libprotobuf 5.29.3#204
regro-cf-autotick-bot wants to merge 9 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:rebuild-absl_grpc_proto-0-1_h603bdb

Conversation

@regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update absl_grpc_proto.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/14074366085 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 26, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15014719873. Examine the logs at this URL for more detail.

@mattip
Copy link
Contributor

mattip commented Mar 26, 2025

Before merging, the ray-specific versions of abseil, libgrpc, libprotobuf need updating to match the ones here, which will require reworking the current patch

@apmorton
Copy link
Contributor

patch incoming

@mattip
Copy link
Contributor

mattip commented Mar 26, 2025

The build is erroring. Did something else change?
ERROR: Error computing the main repository mapping: cannot load '@rules_python//python/pip_install:repositories.bzl': no such file

@apmorton
Copy link
Contributor

apmorton commented Mar 26, 2025

As best I can tell this is some interaction with grpc/grpc@10be77a

I've patched out ray's usages of rules_python and things seem to build locally on linux, but this isn't ideal.

Is there any particular reason ray is so far behind on protobuf/grpc? It'd be great if anyscale could spend some cycles getting up-to-date on those dependencies (or even better enabling us to unvendor these...)

EDIT: ray-project/ray#51395

@apmorton
Copy link
Contributor

Also see: ray-project/ray#51228

@mattip
Copy link
Contributor

mattip commented Mar 26, 2025

I opened ray-project/ray#51673 to upstream the patches from main. There is some interaction with some other version of protobuf in the java build somewhere, I am not sure why that build is seeing older versions of the headers.

@apmorton
Copy link
Contributor

apmorton commented May 2, 2025

@conda-forge-admin please rerender

conda-forge-webservices[bot] and others added 2 commits May 2, 2025 20:45
@apmorton apmorton mentioned this pull request May 12, 2025
3 tasks
@mattip
Copy link
Contributor

mattip commented May 12, 2025

How can this be restarted after #209?

@mattip
Copy link
Contributor

mattip commented May 13, 2025

@h-vetinari something went wrong. Patch files are now missing.

@h-vetinari h-vetinari force-pushed the rebuild-absl_grpc_proto-0-1_h603bdb branch from e7709a4 to 9405890 Compare May 13, 2025 05:52
@mattip
Copy link
Contributor

mattip commented May 13, 2025

Something is off with the way ray is patching zlib. I think the newer grpc recipe needs a different patch, so the file thirdparty/patches/grpc-zlib-fdopen.patch in the ray sources itself needs patching. The failure is

Error applying patch /home/conda/feedstock_root/build_artifacts/ray-packages_1747119190820/work/thirdparty/patches/grpc-zlib-fdopen.patch: Incorrect Chunk: the chunk content doesn't match the target

@h-vetinari
Copy link
Member

You added the following in 4545b72

diff --git a/thirdparty/patches/grpc-zlib-fdopen.patch
b/thirdparty/patches/grpc-zlib-fdopen.patch
index c48a35bc4e..dd434edf19 100644
--- a/thirdparty/patches/grpc-zlib-fdopen.patch
+++ b/thirdparty/patches/grpc-zlib-fdopen.patch
@@ -1,13 +1,13 @@
diff -u bazel/grpc_deps.bzl
--- bazel/grpc_deps.bzl
+++ bazel/grpc_deps.bzl
-@@ -238,6 +238,9 @@
- "https://storage.googleapis.com/grpc-bazel-mirror/github.com/madler/zlib/archive/04f42ceca40f73e2978b50e93806c2a18c1281fc.tar.gz",
- "https://github.com/madler/zlib/archive/04f42ceca40f73e2978b50e93806c2a18c1281fc.tar.gz",
+@@ -53,6 +53,9 @@ def grpc_deps():
+ "https://storage.googleapis.com/grpc-bazel-mirror/github.com/madler/zlib/archive/09155eaa2f9270dc4ed1fa13e2b4b2613e6e4851.tar.gz",
+ "https://github.com/madler/zlib/archive/09155eaa2f9270dc4ed1fa13e2b4b2613e6e4851.tar.gz",
],
+ patches = [
+ "@com_github_ray_project_ray//thirdparty/patches:zlib-fdopen.patch",
-+ ]
++ ],
)
if "com_google_protobuf" not in native.existing_rules():

which I didn't pick up because I was rebasing the new grpc patch from @apmorton here. Not sure why you needed to point to a different zlib, but apparently it's still necessary?

@mattip
Copy link
Contributor

mattip commented May 14, 2025

yes, that is a newer zlib that works with grpc. But now the patching is no longer necessary, so I deleted the upstream patch. Now locally I am getting lots of warnings and then an error:

ERROR: /home/matti/miniforge3/envs/ray-dev/conda-bld/ray-packages_1747206326721/work/src/ray/gcs/gcs_server/BUILD.bazel:137:15: in deps attribute of cc_library rule //src/ray/gcs/gcs_server:gcs_health_check_manager: proto_library rule '@com_github_grpc_grpc//src/proto/grpc/health/v1:health_proto' is misplaced here (expected genrule, cc_library, cc_inc_library, cc_embed_data, go_library, objc_library, cc_import, cc_proto_library, gentpl, gentplvars, genantlr, sh_library, cc_binary or cc_test) and '@com_github_grpc_grpc//src/proto/grpc/health/v1:health_proto' does not have mandatory providers: 'CcInfo'. Since this rule was created by the macro 'ray_cc_library', the error might have been caused by the macro implementation ERROR: /home/matti/miniforge3/envs/ray-dev/conda-bld/ray-packages_1747206326721/work/src/ray/gcs/gcs_server/BUILD.bazel:137:15: Analysis of target '//src/ray/gcs/gcs_server:gcs_health_check_manager' failed

Apparently there are still some incompatibilities in the different dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants