Conversation
apmorton
requested review from
dHannasch,
h-vetinari,
krfricke,
mattip,
timkpaine and
vnlitvinov
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@mattip decided to do this while iterating locally on 2.49 pixi/rattler are a lot faster, so local builds actually get to the ray build much quicker. |
|
No idea whats up with Very odd that non-linux builds are working just fine. |
| + ] | ||
| + ) | ||
| + | ||
| +- SOURCEFORGE_MIRRORS = ["cfhcable", "superb-sea2", "cytranet", "iweb", "gigenet", "ayera", "astuteinternet", "pilotfiber", "svwh"] |
There was a problem hiding this comment.
many of these mirrors are dead, and it causes the build to hang for several minutes while timing out before trying the next mirror.
There was a problem hiding this comment.
Note lzma is also available on github
There was a problem hiding this comment.
I went looking pretty hard for xz-5.2.7.tar.gz with hash 06327c2ddc81e126a6d9a78b0be5014b976a2c0832f492dcfc4755d7facf6d33 from a better mirror and gave up after a while; I'm hoping this is short lived as I intend to start devendoring some things (starting with boost as a proof of concept)
There was a problem hiding this comment.
I intend to start devendoring some things
Whohoo!
I had a dream we removed bazel and use meson-python to build _raylet.so, core/src/ray/raylet/raylet, core/src/ray/gcs/gcs_server.
|
@mattip I believe all the current build will pass momentarily - objections to landing this first and rebasing the 2.49 branch? linux builds are nearly 30 minutes faster with this. |
|
Gr8! Speedups are welcome. |
mattip
added
automerge
|
Did you bump the build number? |
|
yes; bumped to 2 please don't turn on automerge; once builds are green I was going to remove @krfricke, rerender, and merge. |
| - {{ compiler('cxx') }} | ||
| host: | ||
| - python | ||
| number: 2 |
There was a problem hiding this comment.
Ahh, the file name changed ✅
|
Can you also try removing these 2 lines from the windows build? ray-packages-feedstock/recipe/build-core.bat Lines 35 to 36 in 526885e |
3 participants
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)