Skip to content

Use script to update version SHA#237

Merged
mattip merged 11 commits intoconda-forge:mainfrom
AchimGaedkeLynker:patch-1
Sep 28, 2025
Merged

Use script to update version SHA#237
mattip merged 11 commits intoconda-forge:mainfrom
AchimGaedkeLynker:patch-1

Conversation

@AchimGaedkeLynker
Copy link
Contributor

@AchimGaedkeLynker AchimGaedkeLynker commented Sep 26, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #236, Would wish there was an automated way doing this...
Maybe this could help? https://rattler.build/latest/build_options/#post-processing-of-the-package-contents-experimental

@AchimGaedkeLynker
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/recipe.yaml) and found it was in an excellent condition.

@AchimGaedkeLynker AchimGaedkeLynker changed the title fixes #236 fixes #236 - outdated commit sha Sep 26, 2025
@mattip
Copy link
Contributor

mattip commented Sep 26, 2025

I took the liberty of changing the patch to a script, following @apmorton's idea of getting the SHA.

@mattip mattip changed the title fixes #236 - outdated commit sha Use script to update version SHA Sep 26, 2025
@achimgaedke
Copy link

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18052496226. Examine the logs at this URL for more detail.

@AchimGaedkeLynker
Copy link
Contributor Author

AchimGaedkeLynker commented Sep 27, 2025

@AchimGaedkeLynker
Copy link
Contributor Author

I'm a little confused about the flakiness of the azure build machines. Initially I thought the github rate limiting is the only problem, so I addressed it.

In an early iteration I printed a rate limiting header:

2025-09-27T03:08:01.6021470Z  │ │ X-RateLimit-Limit: 60
2025-09-27T03:08:01.6032830Z  │ │ X-RateLimit-Remaining: 0
2025-09-27T03:08:01.6038990Z  │ │ X-RateLimit-Reset: 1758942812
2025-09-27T03:08:01.6040680Z  │ │ X-RateLimit-Resource: core
2025-09-27T03:08:01.6055410Z  │ │ X-RateLimit-Used: 60

indicating that only 60 calls per hour are allowed. That's daunting.

Maybe we can find some github tokens/credentials to use? I've looked at the environment keys, nothing obvious here.
Might be worth checking the git config.

@mattip
Copy link
Contributor

mattip commented Sep 28, 2025

I'm not seeing failures due to rate-limited timeouts. I see a single failure on windows with python3.10

Installing test environment
 │  Successfully updated the test environment
 │ Testing commands:
 │ (ray-packages-feedstock) (ray-packages-feedstock) %SRC_DIR%>IF "" == "" (
 │  
 │  call "%SRC_DIR%\build_env.bat" 
 │ ) 
 │ (ray-packages-feedstock) (ray-packages-feedstock) %SRC_DIR%>python -c "import ray; ray.init(include_dashboard=False)" 
 │ 2025-09-28 01:54:09,167	INFO worker.py:1951 -- Started a local Ray instance.
 │ [2025-09-28 01:54:10,470 E 4840 7992] core_worker_process.cc:232: Failed to register worker to Raylet: IOError: Unknown error worker_id=01000000ffffffffffffffffffffffffffffffffffffffffffffffff

Does the rate limiting only happen when I push a commit to allow the github CIrun runners to proceed? I cannot see the azure CI run log from bf1bfb8.

@AchimGaedkeLynker
Copy link
Contributor Author

I'm not seeing failures due to rate-limited timeouts.

Yeah, I found them appear in an "all or nothing" fashion. Sounds like a "noisy neighbor".

@mattip
Copy link
Contributor

mattip commented Sep 28, 2025

Gahh. Rerendering updated action/checkout to v5, which does not yet work on the cirun images. Reverting.

@AchimGaedkeLynker
Copy link
Contributor Author

🎉 - thanks a lot! This was definitely much more laborious than I imagined.

@mattip mattip merged commit 52038ca into conda-forge:main Sep 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ray._version.commit not up to date for 2.49.2

5 participants