-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add libcamera and related recipes #29477
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcamera/meta.yaml:
For recipes/libcamera/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13972575441. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp can someone help me in landing this? I think this a pretty relevant library. But my c-cpp skills are too low to get it working.... This is also important to have the |
CC @hmaarrfk sorry to ping you on this but I had the feeling that you could also be interested. Forgive me if not... |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcamera/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14022991544. Examine the logs at this URL for more detail. |
if you don't personally need osx support, then don't worry about it. let somebody else come in and help you with it "later". Now you should still move your dependencies to the host section, keep tools like |
at the moment I only need |
Co-authored-by: Mark Harfouche <[email protected]>
yes. mostly doing cross compilation blind is sure to fail.... especially if you are having trouble organizing the dependencies correctly. You can just ask the bot to rerender immeimdately and it gives you a PR that you can edit. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
thanks a lot for the insight and help @hmaarrfk, trying now on |
There is always something odd with meson stuff. Basically, meson pulls in python, and then the build python gets found.... if python is actually a build time dpenednecy, then we can move all the python stuff to the build prefix. But hte "libraries", like libjpegturbo should be in the host section for sure. |
Co-authored-by: Mark Harfouche <[email protected]>
until raspberrypi/libpisp#43 is merged and libpsp is bumped...
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
sorry pinged the staged recipes team by mistake, this is not ready yet |
@hmaarrfk what do you think? I'm not sure about the libcamera-rpi lacking tests. And maybe we could merge this one before adding https://github.com/raspberrypi/picamera2 Let me know your thoughts (and if you want to help maintain this mess I made 😅) |
recipes/libcamera-rpi/meta.yaml
Outdated
|
||
test: | ||
commands: | ||
- echo "Tests not implemented for libcamera-rpi, needs rpicam-apps." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can likely add test for existance of headers and so
files.
recipes/libcamera/meta.yaml
Outdated
|
||
test: | ||
commands: | ||
- cam -l |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are header files and so files expected? if so, add those tests.
See tensorflow or PyTorch for recipes with variants. They have selectors in the meta.yaml. You would have a selector for the source url and the source sha256 |
Hi! This is the staged-recipes linter and your PR looks excellent but I have some suggestions. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcamera/meta.yaml:
For recipes/libcamera/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14116206179. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
don't bother creating different pakcage names, just different build strings. that will make them exclusive. |
https://libcamera.org/index.html
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).