-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gotranx to conda-forge #29480
Add gotranx to conda-forge #29480
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gotranx/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13979019104. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/python, ready for review! |
recipes/gotranx/meta.yaml
Outdated
imports: | ||
- gotranx | ||
|
||
source_files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you're running the tests, these should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d8a7bf9
- pyproject.toml | ||
|
||
commands: | ||
- gotranx --help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- gotranx --help | |
- gotranx --help | |
- pip check |
and add pip
under test/requires
recipes/gotranx/meta.yaml
Outdated
@@ -0,0 +1,60 @@ | |||
{% set name = "gotranx" %} | |||
{% set name_underscore = "gotranx" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you need this separate name. It seems like you could just use name
. If that's the case, remove this and change it accordingly in url
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you. I have now removed this line and changed name_underscore
to name
in the url
in 66cc077
- python {{ python_min }} | ||
- pip | ||
- setuptools | ||
run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is myokit
missing? It appears in the pyproject.toml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that myokit
is not on conda-forge
, which is my I also the reason why I didn't run pip check
.
I did update the package to work without myokit
(see finsberg/gotranx#170), but I think it should be part of the default pip
dependencies since it is a package that would be needed in most scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably advisable to get myokit
up on conda-forge. Once that's available, make sure to add it and then add back in the pip check
.
Co-authored-by: Joshua Adelman <[email protected]>
I also tried to run the test suite, but for some reason the tests just errors, see https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1205130&view=logs&jobId=4cabe686-70ae-553a-7fd0-310379f2cbac&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff Therefore I ended up removing them. It looks like the problem is that |
Adding |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).