Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gotranx to conda-forge #29480

Merged
merged 19 commits into from
Mar 23, 2025
Merged

Add gotranx to conda-forge #29480

merged 19 commits into from
Mar 23, 2025

Conversation

finsberg
Copy link
Contributor

@finsberg finsberg commented Mar 20, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 20, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/gotranx/meta.yaml) and found some lint.

Here's what I've got...

For recipes/gotranx/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13979019104. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gotranx/meta.yaml) and found it was in an excellent condition.

@finsberg finsberg marked this pull request as ready for review March 20, 2025 21:20
@finsberg
Copy link
Contributor Author

@conda-forge/python, ready for review!

imports:
- gotranx

source_files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you're running the tests, these should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d8a7bf9

- pyproject.toml

commands:
- gotranx --help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- gotranx --help
- gotranx --help
- pip check

and add pip under test/requires

@@ -0,0 +1,60 @@
{% set name = "gotranx" %}
{% set name_underscore = "gotranx" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you need this separate name. It seems like you could just use name. If that's the case, remove this and change it accordingly in url.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. I have now removed this line and changed name_underscore to name in the url in 66cc077

- python {{ python_min }}
- pip
- setuptools
run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is myokit missing? It appears in the pyproject.toml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that myokit is not on conda-forge, which is my I also the reason why I didn't run pip check.
I did update the package to work without myokit (see finsberg/gotranx#170), but I think it should be part of the default pip dependencies since it is a package that would be needed in most scenarios.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably advisable to get myokit up on conda-forge. Once that's available, make sure to add it and then add back in the pip check.

@finsberg
Copy link
Contributor Author

I also tried to run the test suite, but for some reason the tests just errors, see https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1205130&view=logs&jobId=4cabe686-70ae-553a-7fd0-310379f2cbac&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff

Therefore I ended up removing them. It looks like the problem is that pytest is unable to find my fixutres which are located conftest.py. Don't know if this is a problem with my package or something else (my conclusion was that it is probably not a problem with my package).

@synapticarbors synapticarbors merged commit 8b0e90a into conda-forge:main Mar 23, 2025
7 checks passed
@synapticarbors
Copy link
Member

synapticarbors commented Mar 23, 2025

Adding myokit here:
#29505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants