-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add floability recipe #29671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add floability recipe #29671
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/floability/meta.yaml:
For recipes/floability/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14344695253. Examine the logs at this URL for more detail. |
1b4f3ed
to
906de1a
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/floability/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14354187603. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I confirm I want to be a recipe maintainer. |
1 similar comment
I confirm I want to be a recipe maintainer. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge/help-python, ready for review! |
recipes/floability/meta.yaml
Outdated
|
||
source: | ||
url: https://github.com/floability/floability-cli/archive/refs/tags/v{{ version }}.tar.gz | ||
sha256: {{ sha256 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just put the sha256
here -- no need to use a jinja variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed jinja variable.
build: | ||
number: 0 | ||
script: {{ PYTHON }} -m pip install . -vv | ||
skip: true # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be noarch: python
?
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because ndcctools is platform-specific.
@conda-forge/help-python, ready for review! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).