Skip to content

Add mmpretrain #29681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Apr 9, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/mat4py/meta.yaml:
    • lints:
      • Feedstock with the same name exists in conda-forge.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mmpretrain/meta.yaml, recipes/mat4py/meta.yaml) and found some lint.

Here's what I've got...

For recipes/mmpretrain/meta.yaml:

  • requirements: run: grad-cam >= 1.3.7,<1.5.0 should not contain a space between relational operator and the version, i.e. grad-cam >=1.3.7,<1.5.0

For recipes/mmpretrain/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • ℹ️ top-level output has some malformed specs:
  • In section run: grad-cam >= 1.3.7,<1.5.0 Requirement spec fields should match the syntax name [version [build]]to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build. There should be no spaces between version operators and versions either: python >= 3.8should bepython >=3.8`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14361338270. Examine the logs at this URL for more detail.

@jeongseok-meta jeongseok-meta changed the title Add mmpretrain and mat4py Add mmpretrain Apr 9, 2025
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Apr 9, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mmpretrain/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/mmpretrain/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14362355386. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@jeongseok-meta
Copy link
Contributor Author

Hi @pavelzw, I've created a new PR based on your PR (#24137) with some modifications. Since the original branch was removed, I couldn't use your commit directly. If there's a way to maintain your authorship, please let me know. Additionally, if you'd like to add yourself as a maintainer, just let me know!

@pavelzw
Copy link
Member

pavelzw commented Apr 9, 2025

all good, thanks for pinging me 👍🏻

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/mmpretrain/meta.yaml) and found some lint.

Here's what I've got...

For recipes/mmpretrain/meta.yaml:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python, or selector on line 31:
    • mmcv # [not win]

For recipes/mmpretrain/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14362447719. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/mmpretrain/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants