Skip to content

Conversation

@ap--
Copy link
Member

@ap-- ap-- commented Apr 14, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14446186175. Examine the logs at this URL for more detail.

@ap--
Copy link
Member Author

ap-- commented Apr 14, 2025

I agree to be a maintainer

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/r-laminr/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: rcannood, falexwolf, lazappi. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-laminr/meta.yaml) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-laminr/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-laminr/meta.yaml:

  • ❌ The requirements section contained an unexpected subsection name. run_constraints is not a valid subsection name.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15092618888. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-laminr/meta.yaml) and found it was in an excellent condition.

@ap--
Copy link
Member Author

ap-- commented May 18, 2025

@conda-forge/help-r ready for review

@cbrueffer
Copy link
Member

Please add conda-forge/r to maintainers, otherwise LGTM.

@ap--
Copy link
Member Author

ap-- commented May 19, 2025

Done ☺️

@ap--
Copy link
Member Author

ap-- commented May 24, 2025

@conda-forge/r sorry for tagging. It'd be great if this could be merged soon. It's currently blocking me on another project.

Thank you 🙏
Andreas

@ap-- ap-- mentioned this pull request May 28, 2025
10 tasks
@ap--
Copy link
Member Author

ap-- commented May 31, 2025

Hi @cbrueffer,

Just checking in on this PR. All checks have passed, and the recipe follows the guidelines in the documentation. Please let me know if there's anything else needed from my side. I'd really appreciate it if this could be reviewed and merged when you get a chance. Thanks for your time and support! 🙏

Cheers,
Andreas

Copy link
Member

@cbrueffer cbrueffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; please add the one comment, then this is good to go.

@ap--
Copy link
Member Author

ap-- commented May 31, 2025

Thank you! I added a comment with a link to the issue.

@cbrueffer
Copy link
Member

cbrueffer commented May 31, 2025

I'll need to find out how to merge this despite the Windows build failing (recurring issue at the moment because of some rcpp issues); the current system seems to disable the merge button when checks fail.

@ap--
Copy link
Member Author

ap-- commented May 31, 2025

@cbrueffer checks are green again. This comment provided the solution: conda-forge/ctng-compilers-feedstock#174 (comment)

@cbrueffer cbrueffer merged commit d1f07cb into conda-forge:main Jun 1, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants