Skip to content

Conversation

@thewchan
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@thewchan thewchan mentioned this pull request May 15, 2025
10 tasks
@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented May 15, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-packcircles/meta.yaml) and found some lint.

Here's what I've got...

For recipes/r-packcircles/meta.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15049488091. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-packcircles/meta.yaml) and found it was in an excellent condition.

@thewchan
Copy link
Contributor Author

Might need yall's help here @conda-forge/help-r @conda-forge/help-c-cpp with some mysterious errors specific to Win build:

Error in inDL(x, as.logical(local), as.logical(now), ...) : 
  unable to load shared object 'D:/bld/r-packcircles_1747324625856/_h_env/lib/R/library/Rcpp/libs/x64/Rcpp.dll':
ERROR: lazy loading failed for package 'packcircles'
  LoadLibrary failure:  The specified procedure could not be found.

@dansmith01
Copy link
Contributor

dansmith01 commented May 23, 2025

@thewchan, I had the same problem (#30078) and got around it by switching from Rcpp to cpp11 (#30127). Definitely something buggy on the build platform, not your code. Hopefully @conda-forge/staged-recipes can fix it soon. Opening an issue might speed that along.

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ap--
Copy link
Member

ap-- commented May 28, 2025

Rcpp.dll can't be loaded due to libstdc++.dll provided in libstdcxx v15.1.0 build h904f734_2 is missing _ZSt21ios_base_library_initv

Adding the following two to the recipe fixed tests for me in #29719

  build:
    - libstdcxx !=14.3.0,!=15.1.0           # [win]

  run_constrained:
    - libstdcxx !=14.3.0,!=15.1.0           # [win]

see: conda-forge/ctng-compilers-feedstock#174
see: https://github.com/conda-forge/pytensor-suite-feedstock/blob/2642442d0810684bf10075c9767ffd7b260a3113/recipe/recipe.yaml#L120-L128

@thewchan
Copy link
Contributor Author

thewchan commented Jun 3, 2025

@ap-- Thanks for the tip I'll give it a try. @conda-forge/r @help-r Just FYI about this one? Not sure if something needs to be done in the toolchain

@thewchan
Copy link
Contributor Author

thewchan commented Jun 3, 2025

@conda-forge/help-r This is ready for review again!

@cbrueffer cbrueffer merged commit 6065700 into conda-forge:main Jun 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants