Skip to content

FEAT: Add tardigrade_error_tools#30240

Merged
carterbox merged 9 commits intoconda-forge:mainfrom
NateAM:feat/add-tardigrade_error_tools
Aug 10, 2025
Merged

FEAT: Add tardigrade_error_tools#30240
carterbox merged 9 commits intoconda-forge:mainfrom
NateAM:feat/add-tardigrade_error_tools

Conversation

@NateAM
Copy link
Contributor

@NateAM NateAM commented Jun 4, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@NateAM
Copy link
Contributor Author

NateAM commented Jun 4, 2025

@kbrindley will you comment on this PR to say you are willing to be a maintainer?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/tardigrade_error_tools/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: kbrindley. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tardigrade_error_tools/meta.yaml) and found some lint.

Here's what I've got...

For recipes/tardigrade_error_tools/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29]

For recipes/tardigrade_error_tools/meta.yaml:

  • ℹ️ The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15433070263. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jun 4, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tardigrade_error_tools/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tardigrade_error_tools/meta.yaml:

  • ℹ️ The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16457297434. Examine the logs at this URL for more detail.

@kbrindley
Copy link
Contributor

I am willing to be a maintainer

@NateAM NateAM force-pushed the feat/add-tardigrade_error_tools branch from 126759d to 610d6c3 Compare June 5, 2025 02:33
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@NateAM
Copy link
Contributor Author

NateAM commented Jun 5, 2025

@conda-forge/help-c-cpp This is ready for review

@NateAM
Copy link
Contributor Author

NateAM commented Jun 16, 2025

@conda-forge-admin, please ping conda-forge/help-c-cpp

Just in case I hadn't signaled this was ready for review properly

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-c-cpp and so here I am doing that.

- /lib64/librt.so.1
- /lib64/libc.so.6
- /lib64/libpthread.so.0
skip: true # [osx or win]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
skip: true # [osx or win]
skip: true # [osx or win]

This software does not seem to be Linux-only, so we should at least enable OSX and see if there are any fixable errors. Windows may be trickier, although since this is using CMake and doesn't appear to have any dependency that are not available on Windows, we should also enable it there.

NateAM and others added 2 commits July 11, 2025 07:59
This works on the local branch.
Co-authored-by: Daniel Nachun <daniel.nachun@gmail.com>
@NateAM NateAM requested a review from danielnachun July 11, 2025 14:01
@NateAM
Copy link
Contributor Author

NateAM commented Jul 11, 2025

@danielnachun Thanks for the review! I made the changes and using the local build utility they seem to work well. I've requested that you re-review.

NateAM and others added 2 commits July 11, 2025 08:35
This problem seems to be something in the CMakeLists file that I think goes beyond the scope of this PR. I'll work towards fixing this in the future.
Co-authored-by: Kyle Brindley <66965948+kbrindley@users.noreply.github.com>
Co-authored-by: Kyle Brindley <66965948+kbrindley@users.noreply.github.com>
Copy link
Contributor

@danielnachun danielnachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should consider splitting this into something like python-tardigrade_error_tools for the Python package and tardigrade_error_tools for the shared library, with python-tardigrade_error_tools depending on tardigrade_error_tools to provide the shared library. This would make it easier for end users who only need the C++ shared library to not have to depend on Python.

@kbrindley
Copy link
Contributor

kbrindley commented Jul 21, 2025

@danielnachun

I think we should consider splitting this into something like python-tardigrade_error_tools for the Python package and tardigrade_error_tools for the shared library, with python-tardigrade_error_tools depending on tardigrade_error_tools to provide the shared library. This would make it easier for end users who only need the C++ shared library to not have to depend on Python.

This may be a good long-term idea. In the short term, we don't have enough (or any) c++-only users to justify splitting the package like this. There is a larger stack of tardigrade_ prefixed libraries downstream of this package and all existing users will need both the c++ and Python together.

This is more obvious when we get to the more user-centric packages, e.g. #30248, where users will use the Python API to perform material model calibrations and then the c++ library to run finite element simulations against those same calibrations.

NateAM and others added 2 commits July 22, 2025 16:47
Co-authored-by: Daniel Nachun <daniel.nachun@gmail.com>
Adding the `stdlib('c')` requirement has fixed this issue.
@NateAM NateAM requested a review from danielnachun July 23, 2025 17:56
@carterbox carterbox merged commit 73a3da4 into conda-forge:main Aug 10, 2025
7 checks passed
@traversaro traversaro mentioned this pull request Jan 14, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants