FEAT: Add tardigrade_error_tools#30240
Conversation
|
@kbrindley will you comment on this PR to say you are willing to be a maintainer? |
|
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tardigrade_error_tools/meta.yaml:
For recipes/tardigrade_error_tools/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15433070263. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tardigrade_error_tools/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16457297434. Examine the logs at this URL for more detail. |
|
I am willing to be a maintainer |
126759d to
610d6c3
Compare
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
@conda-forge/help-c-cpp This is ready for review |
|
@conda-forge-admin, please ping conda-forge/help-c-cpp Just in case I hadn't signaled this was ready for review properly |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-c-cpp and so here I am doing that. |
| - /lib64/librt.so.1 | ||
| - /lib64/libc.so.6 | ||
| - /lib64/libpthread.so.0 | ||
| skip: true # [osx or win] |
There was a problem hiding this comment.
| skip: true # [osx or win] | |
| skip: true # [osx or win] |
This software does not seem to be Linux-only, so we should at least enable OSX and see if there are any fixable errors. Windows may be trickier, although since this is using CMake and doesn't appear to have any dependency that are not available on Windows, we should also enable it there.
This works on the local branch.
Co-authored-by: Daniel Nachun <daniel.nachun@gmail.com>
|
@danielnachun Thanks for the review! I made the changes and using the local build utility they seem to work well. I've requested that you re-review. |
This problem seems to be something in the CMakeLists file that I think goes beyond the scope of this PR. I'll work towards fixing this in the future.
Co-authored-by: Kyle Brindley <66965948+kbrindley@users.noreply.github.com>
Co-authored-by: Kyle Brindley <66965948+kbrindley@users.noreply.github.com>
danielnachun
left a comment
There was a problem hiding this comment.
I think we should consider splitting this into something like python-tardigrade_error_tools for the Python package and tardigrade_error_tools for the shared library, with python-tardigrade_error_tools depending on tardigrade_error_tools to provide the shared library. This would make it easier for end users who only need the C++ shared library to not have to depend on Python.
This may be a good long-term idea. In the short term, we don't have enough (or any) c++-only users to justify splitting the package like this. There is a larger stack of This is more obvious when we get to the more user-centric packages, e.g. #30248, where users will use the Python API to perform material model calibrations and then the c++ library to run finite element simulations against those same calibrations. |
Co-authored-by: Daniel Nachun <daniel.nachun@gmail.com>
Adding the `stdlib('c')` requirement has fixed this issue.
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).