Add libsc & p4est

[claudiushaag]

Checklist

• Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
• License file is packaged (see here for an example).
• Source is from official source.
• Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
• If static libraries are linked in, the license of the static library is packaged.
• Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
• Build number is 0.
• A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
• GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
• When in trouble, please check our knowledge base documentation before pinging a team.

[github-actions]

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libsc/recipe.yaml) and found it was in an excellent condition.

[claudiushaag]

Windows build can be incorporated in the feedstock after cburstedde/libsc#232 is merged.

[claudiushaag]

@conda-forge/help-c-cpp This is ready for review, thanks!
Windows compilability is still pending, therefore skipped.

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libsc/recipe.yaml, recipes/p4est/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/p4est/recipe.yaml:

• ❌ pin_compatible should be used instead of pin_subpackage for libsc because it is not a known output of this recipe: ['p4est'].

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19015751745. Examine the logs at this URL for more detail.}

[conda-forge-admin]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libsc/recipe.yaml, recipes/p4est/recipe.yaml) and found it was in an excellent condition.

[claudiushaag]

Waiting on conda-forge/jansson-feedstock#17 (comment) for json functionality.

[traversaro]

@conda-forge/help-c-cpp This is ready for review, thanks! Windows compilability is still pending, therefore skipped.

Is this draft or ready for review?

[claudiushaag]

@traversaro thank you for checking in! I previously used a patch to make jansson as a dependency work.
I then decided to adress the issue upstream, so waiting for conda-forge/jansson-feedstock#17 to be merged so these recipes are clean.

[traversaro]

@traversaro thank you for checking in! I previously used a patch to make jansson as a dependency work. I then decided to adress the issue upstream, so waiting for conda-forge/jansson-feedstock#17 to be merged so these recipes are clean.

Thanks for the reply, I removed the review-requested label to avoid keeping this in the review queue, ping the help team once this is ready for review again, thansk!

[claudiushaag]

@conda-forge/help-c-cpp this is ready for review now!

The json-feature mentioned earlier is minor and not needed. It depends on something upstream which needs some more time.
I would like to proceed nevertheless.
The pinning is done in accordance with the recent releases:

• libsc v2.8.6 has library version 3.0

• libsc v2.8.7 has library version 4.0

• p4est v2.8.6 has library version 3.0

• p4est v2.8.7 has library version 4.0

Thanks for having a look!

[traversaro]

So, libsc seems to be indeed packaged under this name in several distro: https://repology.org/project/libsc/versions, and also https://repology.org/project/p4est/versions .

[claudiushaag]

Hi @traversaro, thank you for your review!
I resolved a few thinks, a few comments:

to be honest, I am not sure what is the purpouse of the libsc-2.8.7.pc, can you check it out and explain? Thanks!

This stems from the original cmake/pkgconf.cmake file:

# --- generate pkg-config .pc
set(pc_libs_private)
set(pc_req_private "ompi ompi-c orte zlib")

set(pc_req_public "p4est sc")

set(pc_filename p4est-${git_version}.pc)
configure_file(${CMAKE_CURRENT_LIST_DIR}/pkgconf.pc.in ${pc_filename} @ONLY)

install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${pc_filename}
  DESTINATION lib/pkgconfig)

set(pc_target ${pc_filename})
set(pc_link ${CMAKE_INSTALL_PREFIX}/lib/pkgconfig/p4est.pc)

install(CODE "execute_process( \
    COMMAND ${CMAKE_COMMAND} -E create_symlink \
    ${pc_target} \
    ${pc_link}   \
    )"
  )

where the file with the version is created first and then one without a version is symlinked.
The duplication seems to stem from this issue, so the preference on the unversioned .pc-file is known upstream.
I can of course patch this (only with version, only without version...?), but I expected no diminished user experience in keeping it. Tell me which option you prefer.

Which pinning are you referring to?

I was referring to the run_exports which are set up to the patch version. Just a fyi.

[traversaro]

The duplication seems to stem from this issue, so the preference on the unversioned .pc-file is known upstream.
I can of course patch this (only with version, only without version...?), but I expected no diminished user experience in keeping it. Tell me which option you prefer.

Thanks! I think that is ok, as long as we are not interested on Windows (where symlinks are more complicated to handle).

[traversaro]

Thanks, the PR is ready for me. Do you want to squash the commits and rebase yourself or I can do that on merge? Thanks!

[claudiushaag]

You can do that with the merge, no objections from me. Thanks for your help!