Skip to content

Conversation

@marcpaterno
Copy link

Add pycalceff package for calculating binomial efficiencies and their uncertainties.

Package description:
A Python package for calculating binomial efficiencies and confidence intervals using Bayesian methods. Based on Fermilab Technical Memo 2286-cd.

Links:

Checklist:

  • License file is packaged
  • Source is from PyPI
  • Package can be installed with pip
  • Tests pass locally
  • Recipe maintainer: @marcpaterno

Copilot AI review requested due to automatic review settings January 17, 2026 18:28
@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 17, 2026

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pycalceff/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pycalceff/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21113394192. Examine the logs at this URL for more detail.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new conda-forge recipe for pycalceff, a Python package that calculates binomial efficiencies and confidence intervals using Bayesian methods, based on Fermilab Technical Memo 2286-cd.

Changes:

  • Adds a new conda recipe for pycalceff version 1.0.1
  • Configures the package as a noarch Python package with a CLI entry point
  • Includes appropriate dependencies (typer, rich, scipy) and basic tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 21 to 25
- python >=3.12,<3.15
- setuptools >=61.0
- pip
run:
- python >=3.12,<3.15
Copy link

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python version constraint '>=3.12,<3.15' has a very restrictive upper bound that excludes Python 3.15 and later. This may be too restrictive, especially since Python 3.15 may have been released by now (current date: January 2026).

Consider using a less restrictive upper bound or no upper bound unless there's a specific compatibility issue with Python 3.15+. A common pattern for noarch Python packages is to specify only a lower bound (e.g., 'python >=3.12') or use a more flexible upper bound (e.g., 'python >=3.12,<4.0').

Suggested change
- python >=3.12,<3.15
- setuptools >=61.0
- pip
run:
- python >=3.12,<3.15
- python >=3.12
- setuptools >=61.0
- pip
run:
- python >=3.12

Copilot uses AI. Check for mistakes.
Comment on lines 21 to 25
- python >=3.12,<3.15
- setuptools >=61.0
- pip
run:
- python >=3.12,<3.15
Copy link

Copilot AI Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python version constraint '>=3.12,<3.15' has a very restrictive upper bound that excludes Python 3.15 and later. This may be too restrictive, especially since Python 3.15 may have been released by now (current date: January 2026).

Consider using a less restrictive upper bound or no upper bound unless there's a specific compatibility issue with Python 3.15+. A common pattern for noarch Python packages is to specify only a lower bound (e.g., 'python >=3.12') or use a more flexible upper bound (e.g., 'python >=3.12,<4.0').

Suggested change
- python >=3.12,<3.15
- setuptools >=61.0
- pip
run:
- python >=3.12,<3.15
- python >=3.12,<4.0
- setuptools >=61.0
- pip
run:
- python >=3.12,<4.0

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants