-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Add pycalceff: Calculate binomial efficiencies and uncertainties #31943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/pycalceff/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21113394192. Examine the logs at this URL for more detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a new conda-forge recipe for pycalceff, a Python package that calculates binomial efficiencies and confidence intervals using Bayesian methods, based on Fermilab Technical Memo 2286-cd.
Changes:
- Adds a new conda recipe for pycalceff version 1.0.1
- Configures the package as a noarch Python package with a CLI entry point
- Includes appropriate dependencies (typer, rich, scipy) and basic tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
recipes/pycalceff/meta.yaml
Outdated
| - python >=3.12,<3.15 | ||
| - setuptools >=61.0 | ||
| - pip | ||
| run: | ||
| - python >=3.12,<3.15 |
Copilot
AI
Jan 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python version constraint '>=3.12,<3.15' has a very restrictive upper bound that excludes Python 3.15 and later. This may be too restrictive, especially since Python 3.15 may have been released by now (current date: January 2026).
Consider using a less restrictive upper bound or no upper bound unless there's a specific compatibility issue with Python 3.15+. A common pattern for noarch Python packages is to specify only a lower bound (e.g., 'python >=3.12') or use a more flexible upper bound (e.g., 'python >=3.12,<4.0').
| - python >=3.12,<3.15 | |
| - setuptools >=61.0 | |
| - pip | |
| run: | |
| - python >=3.12,<3.15 | |
| - python >=3.12 | |
| - setuptools >=61.0 | |
| - pip | |
| run: | |
| - python >=3.12 |
recipes/pycalceff/meta.yaml
Outdated
| - python >=3.12,<3.15 | ||
| - setuptools >=61.0 | ||
| - pip | ||
| run: | ||
| - python >=3.12,<3.15 |
Copilot
AI
Jan 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python version constraint '>=3.12,<3.15' has a very restrictive upper bound that excludes Python 3.15 and later. This may be too restrictive, especially since Python 3.15 may have been released by now (current date: January 2026).
Consider using a less restrictive upper bound or no upper bound unless there's a specific compatibility issue with Python 3.15+. A common pattern for noarch Python packages is to specify only a lower bound (e.g., 'python >=3.12') or use a more flexible upper bound (e.g., 'python >=3.12,<4.0').
| - python >=3.12,<3.15 | |
| - setuptools >=61.0 | |
| - pip | |
| run: | |
| - python >=3.12,<3.15 | |
| - python >=3.12,<4.0 | |
| - setuptools >=61.0 | |
| - pip | |
| run: | |
| - python >=3.12,<4.0 |
Add pycalceff package for calculating binomial efficiencies and their uncertainties.
Package description:
A Python package for calculating binomial efficiencies and confidence intervals using Bayesian methods. Based on Fermilab Technical Memo 2286-cd.
Links:
Checklist: