-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
add apptools #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add apptools #395
Conversation
Hi! This is the friendly conda-forge-admin automated user. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Restarting the CIs here now that the dependencies are available. |
Does this support Python 3 or is Python 2 only? |
It should support Python 3 as well - the problem seems to be it isn't picking up the new pyface 3.x builds yet. |
Good point. The Windows packages are not released yet. So, let's wait for that to happen. Will check back later and restart AppVeyor. |
Is it desirable to run the full package test suite rather than just the import tests done here? The tests themselves only take about a second to complete. If so, I can update the test section to something like the following: test:
requires:
- nose
- numpy
- pandas
- pytables
commands:
- python -m nose.core -v apptools (for this package, the tests have a number of additional requirements that are available through the default channel). I could do the same for the traits-feedstock, etc. that were already merged |
So, it is generally good to run tests. However, I have tried to use the following rule of thumb. If it is compiled, try to run the tests (or at least some subset that reasonably exercises the code). Particularly, try to do so for anything where numeric accuracy is important (e.g FFTW). If it is Python only and they do CI, I am far less concerned about testing and generally skip it. Importing a bunch of things tends to be just as effective at catching most of the errors you will see (missing dependencies or syntax issues). |
okay, let's leave this one as is then. Can someone restart the CI? |
I think I had, but I don't think everything had been released yet. I have restarted the CIs again. Let's see how this goes. |
Looks like there are some requirements issues that need to be addressed here. That is the cause of the CI failure. |
The Appveyor failure seems to be a time out, but the CirceCI one I need help with. excerpts from the log: The following looks okay, with conda-forge listed as the source for pyface & traitsui
but then this error occurs
The default channel only constains a The conda-forge packages all exist here: |
Okay, I think I see the problem is that so I have to fix that one first. I thought it had passed before we merged it |
Yeah, I think some of the |
Okay, I fixed the Linux build for traitsui, so this is ready to try again. also, both pyface and traitsui released v5.1.0 earlier today. I will wait a bit for them to show up on pypi before updating the feedstocks. |
Fair enough. Restarted the CIs here to make sure everything now works. |
Weird. Still seeing a failure on Windows, but only on Python 3.4 64-bit. |
I don't see any obvious error messages during the build, but it does say:
which would explain why it fails to import Any idea if the following might be related to the problem? The succeeding cases seem to be building into but in the failing Python 3.4 64-bit build things are building in |
The only other thing that looks like an error occurs higher up in the log, but seems related to visual studio, which we aren't using in this recipe:
|
Yeah the fact that it is installing to |
Workarounds in place for the Python 3.4 64-bit Windows issue. AppVeyor has been restarted. |
thanks. ready to merge? |
Absolutely! Thanks for being so patient. |
Well, we are not exactly sure why, but this is not getting converted to a feedstock correctly. See this issue ( #458 ). |
Add apptools as required by #285.
This PR will require both #391 and #394 to be merged first