-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gerrychain recipe #7871
Add gerrychain recipe #7871
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gerrychain:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/gerrychain/meta.yaml
Outdated
requirements: | ||
host: | ||
- geopandas | ||
- matplotlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these packages really necessary at install time? If so, it might be good to look at your package's structure to try to make your imports not happen when calling setup.py.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out---I don't think they are necessary.
I'm glad to see this here, @maxhully. Thanks for keeping the project going so well. If you need help sorting out the install-time deps, let me know. |
The mix of packages that is getting picked up here is really strange. I don't know exactly what the state of the geospatial stack on conda-forge is right now, but I'll try to explain why you have really weird stuff like util-linux coming in. |
@ocefpaf are you aware of any strange incompatibilities in the geospatial stack right now? This recipe seriously goes sideways and pulls in ancient crap from the free channel. If I leave conda-forge off my channel list and only install from defaults, it comes out fine. So it's one or more of the conda-forge packages that have problems, but this stack is so deep that I rue having to figure out which dep exactly is causing it. |
Co-Authored-By: maxhully <[email protected]>
Co-Authored-By: maxhully <[email protected]>
recipes/gerrychain/meta.yaml
Outdated
|
||
about: | ||
home: https://github.com/mggg/GerryChain | ||
license: BSD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is BSD-3-Clause
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just pushed the fix.
Nope. But it is not unlikely that we have old packages with bad metadata and/or something is not playing nice with
I can install the required packages here with only
I'm guess we need to bite the bullet and identify the culprit to remove it 😄 I'll take a closer look tomorrow morning. |
- pip | ||
- python >=3.6 | ||
run: | ||
- geopandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
geopandas
is broken now b/c, even though the conda-forge
stack has gdal
pinned to libgdal 2.4.*
a geopandas
install pulls libgdal 2.3
from defaults
. The staged recipes solution could be to use the strict
channel option (ping @conda-forge/core) or maybe "wait out" the openssl migration and hopefully things will magically work themselves out (until the next migration).
In geopandas
we can:
- drop the optional dependency on
psycopg2
, which is causing the libgdal downgrade - over-specify
libgdal 2.4
to force conda to do the right thing.
Ping @jorisvandenbossche.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with the new geopandas
that pull less dependencies this still solves for libgdal 2.3.3
from defaults
😒
See conda-forge/osmnx-feedstock#40 (comment) for more info.
I'm not sure if we have any other option besides forcing the strict
channel option in conda-forge
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is reasonable to force strict
, especially as that has been what we've told other people to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll send a PR to conda-smithy and staged-recipes tomorrow to implement that. I "forced" it here on CircleCI just as a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxhully we can force libgdal 2.4
here to "get this merged" b/c over-specifying the geopandas dependencies will force the right deps. Or we can wait for conda-forge/conda-forge-ci-setup-feedstock#50. The best solution is of course the latter but if you are in a hurry to get this package in we can do the former.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with waiting! Let me know if there's anything I can do to help out, and thanks for all your work on this---both my recipe and conda-forge in general!
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/gerrychain:
|
OK with me! |
Add gerrychain recipe
This PR adds a recipe for
gerrychain
, a Python library for mathematical research on gerrymandering and redistricting.