Skip to content
This repository was archived by the owner on Nov 10, 2025. It is now read-only.

Make (de)activate scripts POSIX complaint#54

Open
nehaljwani wants to merge 5 commits intoconda-forge:mainfrom
nehaljwani:49
Open

Make (de)activate scripts POSIX complaint#54
nehaljwani wants to merge 5 commits intoconda-forge:mainfrom
nehaljwani:49

Conversation

@nehaljwani
Copy link
Member

@nehaljwani nehaljwani commented Jan 9, 2019

Fixes #49

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. run_exports is not a valid subsection name.

For recipe:

  • It looks like the 'm2w64-toolchain_' output doesn't have any tests.

@nehaljwani
Copy link
Member Author

@conda-forge-admin Please re-render!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@nehaljwani
Copy link
Member Author

My reaction to the linter:

@nehaljwani
Copy link
Member Author

Thoughts @conda-forge/core?

@jakirkham
Copy link
Member

@nehaljwani, it probably ran into this problem. Let's give it another try.

@conda-forge-admin, please re-render.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@jakirkham
Copy link
Member

Appears it's actually re-rendered anyways. Or was your concern with this comment?

@nehaljwani
Copy link
Member Author

Yes, my concern was with the initial comment: It looks like the 'm2w64-toolchain_' output doesn't have any tests.

@nehaljwani
Copy link
Member Author

@conda-forge-admin, please re-render.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. run_exports is not a valid subsection name.

For recipe:

  • It looks like the 'm2w64-toolchain_linux-64' output doesn't have any tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'm2w64-toolchain_linux-64' output doesn't have any tests.

@nehaljwani
Copy link
Member Author

Finally, the linter is happy! @jakirkham, is this good now?

@nehaljwani
Copy link
Member Author

@conda-forge-admin Please rerender!

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@scopatz
Copy link
Member

scopatz commented May 7, 2019

Isn't this feedstock effectively deprecated?

@jakirkham
Copy link
Member

Mostly. It still has the m2w64-toolchain, which is actively used and should probably be factored out. Please see issue ( #57 ) on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toolchain_activate.sh:3: = not found

5 participants