Skip to content

Try deactivation again#107

Draft
h-vetinari wants to merge 2 commits intoconda-forge:mainfrom
h-vetinari:deactivate
Draft

Try deactivation again#107
h-vetinari wants to merge 2 commits intoconda-forge:mainfrom
h-vetinari:deactivate

Conversation

@h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Aug 31, 2025

This was first merged in #93, then reverted in #96, reapplied a couple months later in #95 (while being more conservative with unsetting values that might still be needed), and then reverted again pretty much immediately in #99. Xref #94

Given this history here, I think it would make sense to publish these builds to a separate label first and test them on feedstocks that previously were affected. Happy to do this on a separate branch, if desired.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 31, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20689223793. Examine the logs at this URL for more detail.

@isuruf
Copy link
Member

isuruf commented Feb 5, 2026

What's different between this PR and #95?

@h-vetinari
Copy link
Member Author

h-vetinari commented Feb 5, 2026

What's different between this PR and #95?

I tried to add a test for the failures seen with previous attempts in 9a2f5af (together with conda-forge/clang-win-activation-feedstock#59), but it did not fail as expected. I haven't had time to investigate what difference exists between this test and the failures at the time (or whether the failure has disappeared)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants