Skip to content

Conversation

@forsyth2
Copy link

@forsyth2 forsyth2 commented Oct 18, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@forsyth2
Copy link
Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18607943460. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18607947847. Examine the logs at this URL for more detail.

Copy link
Author

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewdnolan @xylar This PR is ready for review. This one is actually important.

New:

From the cancelled rc2 (#17):

- sqlite
- six >=1.16.0
- globus-sdk >=3.15.0
- globus-sdk >=3.15.0,<4.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, we get AttributeError: 'TransferClient' object has no attribute 'endpoint_autoactivate'. It should be possible to fix the erroring code itself, but I'm not sure how long that will take to debug. I think at this point in the testing period, we should just pin the versions like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forsyth2, excellent instincts on this one. I agree with you on both counts. This should be fixed "properly" in zstash but not right now in the middle of Unified testing, so the upper bound is the right fix for now.

Furthermore, it tells us that we probably want to have an upper bound constraint on globus-sdk in general, so once we support 4.x, we would still have a <5.0 constraint because we know to expect breaking changes.

@forsyth2 forsyth2 mentioned this pull request Oct 18, 2025
7 tasks
@xylar xylar merged commit 8e587fa into conda-forge:dev Oct 18, 2025
5 checks passed
andrewdnolan added a commit to andrewdnolan/e3sm-unified that referenced this pull request Oct 20, 2025
Adds new rc's. Also adds constraint to globus-cli following
conda-forge/zstash-feedstock#18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants