-
-
Notifications
You must be signed in to change notification settings - Fork 5
v1.5.0rc3 #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.5.0rc3 #18
Conversation
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
Documentation on acceptable licenses can be found here. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18607943460. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18607947847. Examine the logs at this URL for more detail. |
forsyth2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewdnolan @xylar This PR is ready for review. This one is actually important.
New:
- E3SM-Project/zstash#393 (pins the versions for
globus-sdk) - E3SM-Project/zstash#394
From the cancelled rc2 (#17):
| - sqlite | ||
| - six >=1.16.0 | ||
| - globus-sdk >=3.15.0 | ||
| - globus-sdk >=3.15.0,<4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, we get AttributeError: 'TransferClient' object has no attribute 'endpoint_autoactivate'. It should be possible to fix the erroring code itself, but I'm not sure how long that will take to debug. I think at this point in the testing period, we should just pin the versions like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forsyth2, excellent instincts on this one. I agree with you on both counts. This should be fixed "properly" in zstash but not right now in the middle of Unified testing, so the upper bound is the right fix for now.
Furthermore, it tells us that we probably want to have an upper bound constraint on globus-sdk in general, so once we support 4.x, we would still have a <5.0 constraint because we know to expect breaking changes.
Adds new rc's. Also adds constraint to globus-cli following conda-forge/zstash-feedstock#18
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)