Conversation
5be8923 to
59d3296
Compare
These tests were created for workarounds needed in libmamba. These do not apply to rattler: - Two of them are about matchspecs, and rattler's parser doesn't need any workarounds - The other one is for Ctrl+C, for which the rattler bindings do not exhibit any problem.
3 tasks
jezdez
approved these changes
Jan 19, 2026
Member
jezdez
left a comment
There was a problem hiding this comment.
Did the workaround not work around?
Member
Author
Some weird interactive vs non interactive code. I guess the fake shell for the tests passes as interactive when it's not really one, so some of the assumptions in xonsh fail: I tried using an env var to disable the welcome message which is apparently involved in this terminal size query, so we'll see. If this doesn't work, I'll just wait for the new setup-miniconda release (tomorrow, I guess). |
Member
Author
|
Ugh, setup-miniconda it is then. Can you take a look when you have the chance, @jezdez? Thanks! |
Member
Author
|
I'll merge for now, since any updates will need a bump in setup-miniconda anyway. |
Member
|
@jaimergp Released the setup-miniconda update |
Member
Author
|
Let's see if #34 works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there were some outdated parts in the workflow (e.g. truststore, linux-aarch64 support) so it was time to refresh it.
Since we are only testing one Python version (3.10) to keep thing light in this still in-progress repo, I changed the matrix configuration to
includebecause it's way clearer when we have so few cases.I also:
tests/test_workarounds.py, since they don't apply forrattler(more details in commit message)added a temporary workaround for Translate POSIXdoesn't work, will fix in a different PRsettoxonsh's equivalent setup-miniconda#442