Activate default environment instead of base environment#414
Merged
jaimergp merged 16 commits intoconda-incubator:mainfrom Oct 23, 2025
Merged
Activate default environment instead of base environment#414jaimergp merged 16 commits intoconda-incubator:mainfrom
base environment#414jaimergp merged 16 commits intoconda-incubator:mainfrom
Conversation
jaimergp
reviewed
Oct 14, 2025
src/conda.ts
Outdated
| )) as string; | ||
| const config = JSON.parse(configsOutput) as types.ICondaConfig; | ||
| if (config.default_activation_env) { | ||
| return config.default_activation_env === envName; |
Member
There was a problem hiding this comment.
Can this be also a full path instead of a name? And, in that case, do you need to resolve the paths?
Contributor
Author
There was a problem hiding this comment.
In principle, you can use a full path, even though it seems unlikely that an installer would use a full path in the config file (even though it could be used as a function input). I added some path expansion logic, but testing all possible combinations here would quickly result in a lot of CI time being used.
I think we need to create an issue to start unit testing our functions with jest.
Member
There was a problem hiding this comment.
I think we need to create an issue to start unit testing our functions with jest.
Let's do that
jaimergp
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
condahas replacedauto_activate_basewithauto_activateto allow for setting default environments to different environments than thebaseenvironment.On Windows, however, the
baseenvironment is hard-coded as the primary activation environment, overriding default environment settings. Additionally, other environments are only activated when they are not thebaseenvironment, which would make it impossible to activate thebaseenvironment if a default environment is set in a.condarcfile.The action's input options also still reflect the old language in
conda.auto-update-baseshould be deprecated in favor ofauto-update.Summary of changes
auto-activate-baseinput parameter and replace withauto-activate.auto_activate_basethe option depends on thecondaversion and is thus not actionable by the user.baseenvironment.isValidActivatenow checks if the target environment is the default environment.baseenvironment.