Fixed FileNotFoundError: [WinError 206] The filename or extension is too long #5780
+51
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original algorithm could result in command line calls that were too large. For example, this was causing "The filename or extension is too long" errors on Windows for projects with many files. Also added the ability to specify the max chunk size length to use via a CONDA_BUILD_MAX_CMD_LEN environment variable. Fixes conda#5122
changed limits for max cmd line: 8190 for windows, 32760 otherwise. no consistent for both regex_files_rg and compile_missing_pyc added MAX_CMD_LINE_LENGTH variable to avoid duplication
Contributor
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @jacobwilliams. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1198), and ping the bot to refresh the PR. |
Author
|
anybody home? |
Contributor
|
@conda-bot check |
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5780 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5122
This PR includes the following changes:
chunksalgorithm for splitting up long command line calls. The old one was buggy and also used the wrong max length on windows.CONDA_BUILD_MAX_CMD_LENcan alternately be used to set the max cmd line length.utilsand a newMAX_CMD_LINE_LENGTHvariable added to hold this value.Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?