Show target platform instead of host in cross-platform export#911
Merged
jezdez merged 5 commits intoconda:mainfrom Apr 27, 2026
Merged
Show target platform instead of host in cross-platform export#911jezdez merged 5 commits intoconda:mainfrom
jezdez merged 5 commits intoconda:mainfrom
Conversation
conda-bot
added
the
cla-signed
Contributor
|
I like it. We might add a test; resiliency against self.subdirs with no noarch value; and definitely a news/ item. |
jezdez
approved these changes
Apr 23, 2026
The progress message during cross-platform lockfile export always displayed context.subdir (the host platform) instead of the actual target platform being solved. Use self.subdirs to display the correct target, matching the pattern already used for init_libmamba_context. Fixes conda/conda#15920
jezdez
force-pushed
the
fix/cross-platform-display
branch
from
796f78b to
47b576b
Compare
Combines the cross-platform target and noarch-only fallback cases into a single parameterized test to reduce duplication.
jezdez
changed the title
Member
|
Blocked by conda-forge/pytest-codspeed-feedstock#25 |
Contributor
Author
|
Heads up @jezdez, the feedstock PR you flagged (conda-forge/pytest-codspeed-feedstock#25) merged on 2026-04-24 so the aarch64 jobs should be unblocked now. I pushed an empty commit (90a1af1) to retrigger CI, but the Tests workflow is sitting at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.subdirsinstead ofcontext.subdirin the progress message during cross-platform lockfile exportWhy
When running
conda export --lockfile --platform linux-64from macOS, the progress spinner displays "Platform: osx-arm64" for every target platform solve instead of the actual target being solved (e.g., "linux-64", "win-64").The fix uses the same
self.subdirspattern already used on line 130 forinit_libmamba_context, which correctly passes the target platform.Verification
One-line change. The existing pattern at line 130 (
next(s for s in self.subdirs if s != "noarch")) validates this approach.Fixes #919