Conversation
3 tasks
1337827 to
af290bb
Compare
jezdez
reviewed
Feb 23, 2026
Contributor
ForgottenProgramme
left a comment
There was a problem hiding this comment.
Thanks for creating this, @danyeaw.
I looked through the PR and I find some of the tests redundant. Added comments pointing those out.
jaimergp
reviewed
Feb 24, 2026
0b9912a to
494f85b
Compare
This was referenced Feb 25, 2026
ForgottenProgramme
approved these changes
Feb 25, 2026
Contributor
ForgottenProgramme
left a comment
There was a problem hiding this comment.
LGTM!
Suggestions made by other reviewers are all relevant and can be tracked in different tickets. 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #249.
Wheel RECORD includes the hash value as a base64 encoded value per PEP 376 and updated in the Python Package User Guide which includes hash algorithm followed by the equals character =, followed by the urlsafe-base64-nopad encoding of the digest with trailing = removed.
When unpacking an archive, conda creates metadata for each package in its
conda-meta/<package.json>file in thepaths_datasection. The format of this hash is a hex value (the standard sha256sum format) of the sha256 for thesha256andsha256_in_prefixfields.The wheel package extractor was taking the hashes from the wheels RECORD and putting it in to the conda metadata directly while unpacking the .whl. This resulted in base64 hashes to appear in conda metadata and resulted in a ValueError when conda-rattler-solver tried to transform the hashes from a conda prefix record to a rattler prefix record.
Since we were also computing hashes in the build module, I centralized the hash calculations in to the utils module and added unit tests for them.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?