Merged
Conversation
dholth
reviewed
Feb 26, 2026
conda_pypi/package_extractors/whl.py
Outdated
| separators=(",", ": "), | ||
| ) | ||
| fo.write(json_str) | ||
| json_str = json.dumps(obj, indent=2, sort_keys=True, separators=(",", ": ")) |
Contributor
There was a problem hiding this comment.
odd 'old' choice. For me the most compact (",", ":") is best and if we can get away with putting it all on one line (no indent argument) even better. These files probably do at least warrant the indent for readability however.
Member
Author
There was a problem hiding this comment.
Thanks, updated it to the more compact form.
dholth
reviewed
Feb 26, 2026
dholth
reviewed
Feb 26, 2026
dholth
reviewed
Feb 26, 2026
Co-authored-by: Daniel Holth <dholth@anaconda.com>
Co-authored-by: Daniel Holth <dholth@anaconda.com>
danyeaw
force-pushed
the
fix-man-pages
branch
from
e724be0 to
71cf498
Compare
dholth
reviewed
Feb 26, 2026
dholth
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #255 by adding support for the other wheel schemas including data and scripts. I also did some refactoring to make use of Pathlib for better readability.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?