Skip to content

Fix analyze step stuck with no code changes#264

Merged
jezdez merged 1 commit intoconda:mainfrom
danyeaw:fix-analyze-step
Mar 2, 2026
Merged

Fix analyze step stuck with no code changes#264
jezdez merged 1 commit intoconda:mainfrom
danyeaw:fix-analyze-step

Conversation

@danyeaw
Copy link
Member

@danyeaw danyeaw commented Mar 2, 2026

Description

I noticed that PRs #260 and #262 were stuck on the analyze step. We were filtering on paths to not rerun all the tests, but then the analyze step was getting stuck. This PR uses the solution from the conda repo to filter changes using the dorny/paths-filter action. This will allow the analyze run to see the other jobs passed as allowed-skips.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@danyeaw danyeaw requested a review from a team as a code owner March 2, 2026 18:17
@github-project-automation github-project-automation bot moved this to 🆕 New in 🔎 Review Mar 2, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 2, 2026

Merging this PR will not alter performance

✅ 5 untouched benchmarks


Comparing danyeaw:fix-analyze-step (b6e2c9b) with main (c562b4f)

Open in CodSpeed

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, huh!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Approved in 🔎 Review Mar 2, 2026
@jezdez jezdez merged commit 7bda810 into conda:main Mar 2, 2026
38 checks passed
@github-project-automation github-project-automation bot moved this from ✅ Approved to 🏁 Done in 🔎 Review Mar 2, 2026
@danyeaw danyeaw deleted the fix-analyze-step branch March 2, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

3 participants