Skip to content

Make test-package-with-data a flat-layout package to restore skipped failing test #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danyeaw merged 4 commits into from
Mar 10, 2026
+6 −6
Merged

Make test-package-with-data a flat-layout package to restore skipped failing test #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2381ae6
Make it a flat layout package
agriyakhetarpal Mar 2, 2026
999f84a
Undo skip on this test
agriyakhetarpal Feb 24, 2026
8c7eac5
Merge branch 'main' into undo-test_install_installer_data_files_prese…
agriyakhetarpal Mar 9, 2026
4144ef3
Merge branch 'main' into undo-test_install_installer_data_files_prese…
danyeaw Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/packages/has-data-files/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
setup(
name="test-package-with-data",
version="1.0.0",
packages=find_packages(where="src"),
package_dir={"": "src"},
packages=find_packages(),
data_files=[
("share/test-package-with-data/data", ["src/test_package_with_data/data/test.txt"]),
("share/test-package-with-data", ["src/test_package_with_data/share/config.json"]),
("share/test-package-with-data/data", ["test_package_with_data/data/test.txt"]),
("share/test-package-with-data", ["test_package_with_data/share/config.json"]),
],
)
Empty file added tests/packages/has-data-files/test_package_with_data/__init__.py
View file
Open in desktop
Empty file.
1 change: 1 addition & 0 deletions tests/packages/has-data-files/test_package_with_data/data/test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
test data file
1 change: 1 addition & 0 deletions tests/packages/has-data-files/test_package_with_data/share/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
3 changes: 1 addition & 2 deletions tests/test_installer_data_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ def test_package_wheel_path(tmp_path_factory):
)


@pytest.mark.skip(reason="Test has CI-only failures that need investigation")
def test_install_installer_data_files_present(
tmp_env: TmpEnvFixture,
test_package_wheel_path: Path,
Expand All @@ -54,7 +53,7 @@ def test_install_installer_data_files_present(
build_path.mkdir()

with tmp_env("python=3.12", "pip") as prefix:
python_executable = Path(prefix, get_python_short_path()) / "python"
python_executable = Path(prefix, get_python_short_path())

installer.install_installer(
str(python_executable),
Expand Down
Loading