Fix conda-package-streaming dependency missing

[danyeaw]

Description

Fixes #270 by adding conda-package-streaming as a dependency and reorganizing the dependencies. I also dropped a test introduced in #259. It was testing that extras in MatchSpec work, which isn't supported syntax yet. This test must have been passing by coincidence for that PR.

Checklist - did you ...

• Add a file to the news directory (using the template) for the next release's release notes?
• Add / update necessary tests?
• Add / update outdated documentation?

[codspeed-hq]

Merging this PR will degrade performance by 30.96%

❌ 1 (👁 1) regressed benchmark
✅ 4 untouched benchmarks

Performance Changes

	Benchmark	BASE	HEAD	Efficiency
👁	test_build_conda[imagesize]	51.1 ms	74.1 ms	-30.96%

---

_{Comparing danyeaw:fix-dependency (3124364) with main (836a0f3)¹}

Footnotes

1. No successful run was found on main (44812fe) during the generation of this report, so 836a0f3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[soapy1]

Looks great, just 2 small questions!

It looks like the recipe already had the dependencies right 👍 But it looks like the conda-forge recipe is missing conda-package-streaming.

edit: nice, I see the follow up cf pr conda-forge/conda-pypi-feedstock#31

[soapy1]

Will we want to re-introduce this test at some point? Is it worth commenting it out so that we don't forget re-enabling it?

[danyeaw]

Hi @soapy1, we would have to add this as a new conda feature to add extras to a MatchSpec with something like conda install requests[extras=socks] since using bracket syntax is already conflicts with the normal MatchSpec syntax. Once that is available, we could add tests here with it, but I'm not sure that we should keep it around for then. I feel a bit embarrassed that I added a test for something that couldn't be correct, my fault.