Draft
Conversation
Member
Author
|
Hey @baszalmstra, I know you have spent some time thinking about conditional marker conversion. Would you mind please taking a quick peak at the |
|
I think the best way to test this is to have a large set of conditions/requirements convert them to conda requirements and snapshot them. That makes it easy to see what the conversion will do in many different cases, whether it makes, and whether it regressed. (You might already have that, I might have missed it) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blocked by conda-incubator/conda-rattler-solver#46.
Closes #247. In py-rattler 0.23.0, they updated support for the v3 repodata with conditionals/extras which is defined in:
Currently the conditional/extras CEP draft defines the extras field to be called
extras. py-rattler is using the fielddepends_extra, so I am going with that to match the implementation and I posted about this on Zulip.This also enabled usage of conditional markers which requires quite a lot of conversion:
python...MatchSpec fragments, includingpython_version not in "x, y"->(python!=x and python!=y).__win,__linux,__osx,__unix).extra_depends, with remaining non-extra marker logic encoded via[when="..."].One thing I'm not sure about is that I am using a private
_markermethod from the packaging library in one place. I tried to keep the usage isolated to one area, and it is for only test metadata generation. I think this is much better than using regex to parse the markers.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?