fix: use python_min in skip conditions for noarch Python recipes - #480
fix: use python_min in skip conditions for noarch Python recipes#480janjagusch wants to merge 1 commit into
python_min in skip conditions for noarch Python recipes#480Conversation
Per CFEP-25 standards, V1 noarch Python recipes only define `python_min` in their variant configuration, not `python`. When converting V0 recipes to V1 format, Python version selectors like `[py<310]` should now produce `match(python_min, "<3.10")` instead of `match(python, "<3.10")` for noarch Python packages. This prevents rattler-build from skipping all variants due to an undefined `python` variable. Fixes conda#479 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Apologies for the slow response on this, I have been absolutely swamped by other work lately. At first glance I think this is a great change and I really appreciate the contribution! However I think this may be specific to how conda-forge operates and not necessarily how everyone in the wider Conda Community operates. We try to keep Conda Recipe Manager and its tooling accessible for all Conda users. The way we've handled this in the past is to offer additional flags to Once a flag is added to Let me know if that sounds like a good plan. Thanks! |
Thanks for the pointer, @schuylermartin45. I must admit I wasn't aware that CRM provides tooling for the whole Conda community, and not just Conda-Forge. I'll try to look into your suggestion this week. :) |
Summary
Per CFEP-25 standards, V1 noarch Python recipes only define
python_minin their variant configuration, notpython. This PR fixes the V0→V1 recipe conversion to usepython_mininstead ofpythonin skip condition match expressions for noarch Python packages.Changes
_is_noarch_python()helper method to detectnoarch: pythonrecipes_upgrade_selectors_to_conditionals()to usepython_minfor noarch Python recipesnoarch-python-skip.yamlfixtureBefore
After
Related Issues
python_mininstead ofpythonin skip conditions for noarch Python recipes #479Test Plan
noarch-python-skip.yamlthat verifies the fixselector-match-upgrades.yamltest still passes (non-noarch recipes still usepython)test_recipe_parser_convert.pypassThis PR was generated with the assistance of Claude Code