Check teams from branch PRs by jaimergp · Pull Request #313 · conda/governance

jaimergp · 2025-11-20T15:27:40Z

Description

Follow up to Documenting sub-teams as YAML files (and verified using a JSON Schema) #147
Closes Record-keeping for subteams #86

jaimergp · 2025-11-24T20:01:17Z

Ok, I think we are getting closer to something functional here.

Summary of features:

scripts/check_teams.py will check whether the local files match Github's info:
- Are all teams mentioned in a file?
- Do memberships match?
- Does repo access match?
- Are there any users with individual access?
- Do descriptions match?
scripts/schemas.py encodes the YAML document schema. It also has a generate argument that will dump the Github info to a file, if missing. Useful for bootstrapping new teams.
steering.csv and emeritus.csv are also expressed as YAML now.
This is paired with Republish governance, code of conduct and teams from conda/governance conda-dot-org#285 for pretty printing.

Pending work:

I combed through the organizations and issues to add as many links for membership provenance as possible, but a few are still missing.
Some teams are duplicated across orgs. Some in conda-incubator don't make sense anymore, we should remove them?
Team descriptions probably need some work. And we should probably add a long_description field too so teams can add more docs about how they function, responsibilities, etc.
Individual access checks need a more powerful token, I think. Or maybe we don't want to check this in all repositories, only key ones.

I know this is going to be a nightmare to review, so I suggest merging a good baseline we are happy with, and adjusting the files in several PRs little by little until the CI passes. Especially if we need to update team composition and other metadata in Github (for bookkeeping).

scripts/check_teams.py

danyeaw · 2025-11-24T20:53:22Z

This is amazing @jaimergp! I agree that getting this merged as a baseline that then we can update overtime is a great strategy.

jaimergp · 2025-11-25T10:09:45Z

Posting the pre-commit logs here because they don't fit in pre-commit.ci:

Validate files with jsonschema...........................................Failed
- hook id: check-jsonschema
- exit code: 1
  Schema validation errors were encountered.
    teams/conda/community-contributors.yml::$.description: None is not of type 'string'
    teams/conda/community-contributors.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda/community-contributors.yml::$.charter: None is not of type 'string'
    teams/conda/community-contributors.yml::$.links: None is not of type 'array'
    teams/conda-incubator/ceps.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/ceps.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/ceps.yml::$.links: None is not of type 'array'
    teams/conda-incubator/setup-miniconda.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/setup-miniconda.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/setup-miniconda.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda-incubator/constructor.yml::$.description: None is not of type 'string'
    teams/conda-incubator/constructor.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/constructor.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/bots.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/bots.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/bots.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda-incubator/rattler.yml::$.description: None is not of type 'string'
    teams/conda-incubator/rattler.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/rattler.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/rattler.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-project.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-project.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-project.yml::$.links: None is not of type 'array'
    teams/conda-incubator/infrastructure.yml::$.description: None is not of type 'string'
    teams/conda-incubator/infrastructure.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/infrastructure.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/infrastructure.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-mirror.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-mirror.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-mirror.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-sh.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-sh.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-sh.yml::$.links: None is not of type 'array'
    teams/conda-incubator/shells.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/shells.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/shells.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-lockfiles.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-lockfiles.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-lockfiles.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda/conda-maintainers-project-management.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-colab.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-colab.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-colab.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-oci.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-oci.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-oci.yml::$.links: None is not of type 'array'
    teams/conda/ceps.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda/ceps.yml::$.charter: None is not of type 'string'
    teams/conda/ceps.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda/conda-core.yml::$.description: None is not of type 'string'
    teams/conda/conda-core.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda/conda-core.yml::$.charter: None is not of type 'string'
    teams/conda/conda-core.yml::$.links: None is not of type 'array'
    teams/conda-incubator/builds-tools.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/builds-tools.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/hatch-conda-build.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/hatch-conda-build.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/hatch-conda-build.yml::$.links: None is not of type 'array'
    teams/conda-incubator/condastats.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/condastats.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/condastats.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-dot-org.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-dot-org.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-dot-org.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-completions.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-completions.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-completions.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda-incubator/code-of-conduct.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/code-of-conduct.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/code-of-conduct.yml::$.links: None is not of type 'array'
    teams/conda/distribution-contractors.yml::$.description: None is not of type 'string'
    teams/conda/distribution-contractors.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda/distribution-contractors.yml::$.charter: None is not of type 'string'
    teams/conda/distribution-contractors.yml::$.links: None is not of type 'array'
    teams/conda-incubator/design.yml::$.description: None is not of type 'string'
    teams/conda-incubator/design.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/design.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/design.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-tutorial.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-tutorial.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-tutorial.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-env-builder.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-env-builder.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-env-builder.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-libmamba-solver.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-libmamba-solver.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/installer.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/installer.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/installer.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda-incubator/docs.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/docs.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/docs.yml::$.links: None is not of type 'array'
    teams/conda-incubator/implementation.yml::$.description: None is not of type 'string'
    teams/conda-incubator/implementation.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/implementation.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/implementation.yml::$.links: None is not of type 'array'
    teams/conda-incubator/steering-council.yml::$.description: None is not of type 'string'
    teams/conda-incubator/steering-council.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/steering-council.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/steering-council.yml::$.links: None is not of type 'array'
    teams/conda-incubator/conda-plugins.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/conda-plugins.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/conda-plugins.yml::$.links: None is not of type 'array'
    teams/conda-incubator/fetch.yml::$.description: None is not of type 'string'
    teams/conda-incubator/fetch.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/fetch.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/fetch.yml::$.links: None is not of type 'array'
  Schema validation errors were encountered.
    teams/conda-incubator/content.yml::$.description: None is not of type 'string'
    teams/conda-incubator/content.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/content.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/content.yml::$.links: None is not of type 'array'
    teams/conda-incubator/relock-conda.yml::$.charter: None is not one of ['dynamic', 'static', 'project']
    teams/conda-incubator/relock-conda.yml::$.charter: None is not of type 'string'
    teams/conda-incubator/relock-conda.yml::$.links: None is not of type 'array'

jezdez · 2025-11-25T10:46:25Z

I don't agree with merging snapshots of the progress here as a baseline, since that has the smell of not taking governance information seriously, and I don't want to end up in legal debates later about why we merged this.

That said, if you need a break from this, or frankly if you don't have the access needed because of the org ownership situation, I'm happy to devote time to carry this over the finish line with the items you wrote above. I'm happy to devote time to it this week.

jaimergp · 2025-11-25T10:51:16Z

That said, if you need a break from this, or frankly if you don't have the access needed because of the org ownership situation, I'm happy to devote time to carry this over the finish line with the items you wrote above. I'm happy to devote time to it this week.

I have time and energy for this, but I don't have permissions to do any cleanups in the conda organization. I can do the ones in conda-incubator, but even for that I'd like consensus.

I don't agree with merging snapshots of the progress here as a baseline, since that has the smell of not taking governance information seriously, and I don't want to end up in legal debates later about why we merged this.

I don't have strong opinions on how we proceed, but some counterpoints:

main already contains in-progress work.
the situation is quite dire with outdated permissions.
it will be very tricky to follow cleanup decisions if all the teams are removed as part of the same PR. I'd prefer having one team (or a few related ones) removed per PR for traceability.

jaimergp · 2025-11-25T10:51:50Z

Oh, and I also need help reviewing the types of teams. Not clear how some of them were created and with which mission.

jaimergp · 2025-11-25T23:50:25Z

@kenodegard shared that a governance-defined team does not necessarily correspond to a Github team
Hence, a YAML file should be able to represent the same team across several organizations
The schema needs to be updated to reflect that, and then we can do the different directories for conda and conda-incubator. To extend this to arbitrary organizations and repositories, we'll probably need to enumerate in which organizations the team must be found with given members. And also which repositories should they have access too (in each organization, but that's trivial to match).

…olds the GH teams representing the governance team.

jezdez · 2025-12-03T09:18:13Z

FYI, I just renamed the builds tools team to build tools team, as I think this was a typo when we created the team.

jaimergp · 2025-12-03T10:39:43Z

We will also need to rename the Zulip channel: #builds-tools

jezdez

I'm in favor of this change, thanks for working on it! I left a few comments, just for practical purposes and maybe as follow-up if you agree.

jezdez · 2026-01-15T12:46:32Z

steering.csv

I think this might break a few links that we pointed at this :-/ Since we didn't version it, I'm wondering if we should keep it where it is, there is sadly no web based symlink support

I'll update the links in the respective places (that's how I did it for conda-forge's move to conda-forge/governance. There are not many instances, and most of them are using the hash-pinned URL, so it should be ok.

jezdez · 2026-01-15T12:48:02Z

README.md

 ### Emeritus Steering

-[Steering Council](#steering-council) members that are inactive (commits, GitHub comments/issues/reviews, dev meetings, and voting on polls) in the past six months will be asked if they want to become **Emeritus Steering** members. One week after asking, if the inactive Steering Council member has not responded, they will be automatically moved to emeritus status. Any Steering Council member can also request to become Emeritus if they wish to do so (e.g. taking a sabbatical or long vacation). Emeritus Steering members can be brought back to active Steering Council membership at anytime, assuming there is space and no other policies (e.g., [shared funding](#shared-funding-membership-restrictions), [council size](#steering-council-size), etc.) are violated. Emeritus Steering Council members cannot vote. When the status of a member changes, the [`steering.csv`](steering.csv) and [`emeritus.csv`](emeritus.csv) files should be immediately updated to reflect the member's new position.
+[Steering Council](#steering-council) members that are inactive (commits, GitHub comments/issues/reviews, dev meetings, and voting on polls) in the past six months will be asked if they want to become **Emeritus Steering** members. One week after asking, if the inactive Steering Council member has not responded, they will be automatically moved to emeritus status. Any Steering Council member can also request to become Emeritus if they wish to do so (e.g. taking a sabbatical or long vacation). Emeritus Steering members can be brought back to active Steering Council membership at anytime, assuming there is space and no other policies (e.g., [shared funding](#shared-funding-membership-restrictions), [council size](#steering-council-size), etc.) are violated. Emeritus Steering Council members cannot vote. When the status of a member changes, the corresponding `teams/` YAML files should be immediately updated to reflect the member's new position.


I think it best if we add github issue templates to do this, since I'm worried we'll forget :-/

- build-tools: Move travishathaway to emeritus - communications: Add dashagurova - constructor: Add lrandersson (#332), move mcg1969 to emeritus - infrastructure: Add jaimergp GitHub team changes still needed: - coc-committee: Remove jezdez - communications: Remove tnabtaf - constructor: Add hmaarrfk

jezdez · 2026-01-29T01:19:52Z

Hey Jaime! I pushed a commit to sync the member lists with current GitHub org membership:

Changes:

build-tools: Move travishathaway to emeritus
communications: Add dashagurova
constructor: Add lrandersson (Request to join the conda/constructor team #332), move mcg1969 to emeritus
infrastructure: Add you! 🎉

GitHub team cleanup still needed (separate from this PR):

coc-committee: Remove jezdez
communications: Remove tnabtaf
constructor: Add hmaarrfk

This also supersedes #341 (lrandersson addition).

jaimergp added 5 commits November 20, 2025 16:27

Open PRs from branch

70158a1

enable PR triggers for workflow file

82e69ea

Check access to repos

2300742

pre-commit

2b46a7e

Fix deprecation warnings

98e2233

jaimergp changed the title ~~Open PRs from branch~~ Check teams from branch PRs Nov 20, 2025

pre-commit again

f8c73f5

jaimergp mentioned this pull request Nov 20, 2025

Record-keeping for subteams #86

Open

jaimergp added 11 commits November 20, 2025 17:12

refactor the diff reporting

63f4240

de-prio github token

20fff06

sort teams

4c126fb

pre-commit

b542c55

move under conda/

b9545ff

Auto generate all files for missing teams

4e49f18

ignore advisories

0eb7a54

add Sophia to conda-pypi

81d0b91

Add some descriptions

da9223c

Small refactor for the script

c54f9c6

Start script to render MDs

6e7035c

jaimergp added this to conda Roadmap and Sprint Planning Nov 24, 2025

github-project-automation bot moved this to Sorting ⚙️ in conda Roadmap and Sprint Planning Nov 24, 2025

jaimergp self-assigned this Nov 24, 2025

jaimergp moved this from Sorting ⚙️ to In Progress 🏗️ in conda Roadmap and Sprint Planning Nov 24, 2025

jaimergp removed this from conda Roadmap and Sprint Planning Nov 24, 2025

jaimergp added 6 commits November 24, 2025 09:50

Fill in some more teams

dc028ea

WIP

0dd5bd8

coerce to empty string

55c5890

Check if users have direct access to repos, instead of via teams

b3035d6

pre-commit

cbe5b27

clarify permissions needed

bd5aaf2

jaimergp requested review from a team, jezdez and kenodegard November 24, 2025 20:28

danyeaw reviewed Nov 24, 2025

View reviewed changes

scripts/check_teams.py Outdated Show resolved Hide resolved

Handle strings too

d627fb6

jaimergp marked this pull request as ready for review November 25, 2025 10:10

jaimergp requested a review from a team as a code owner November 25, 2025 10:10

jezdez self-assigned this Nov 25, 2025

Change scopes to resources and codeowners to repos. teams h…

740715b

…olds the GH teams representing the governance team.

jaimergp mentioned this pull request Dec 1, 2025

Status Report (2025-11-28) Quansight-Labs/conda-ecosystem-sta-mgmt#99

Closed

jaimergp and others added 2 commits December 2, 2025 12:27

Allow a governance team to span several Github teams

e93bf25

Fix name typo in build-tools YAML file

206530c

jaimergp added 3 commits December 3, 2025 11:42

Update zulip link for build-tools

114b2a6

Add disclaimer comment

f3b3275

Remove disclaimer from script

3af6fca

jezdez reviewed Jan 15, 2026

View reviewed changes

h-vetinari mentioned this pull request Jan 19, 2026

CI not usable in PRs conda-forge/governance#17

Open

jezdez mentioned this pull request Jan 29, 2026

Sync team files with GitHub org membership #342

Closed

jezdez mentioned this pull request Jan 29, 2026

Add lrandersson to constructor team #341

Closed

Conversation

jaimergp commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

jaimergp commented Nov 24, 2025

Uh oh!

Uh oh!

danyeaw commented Nov 24, 2025

Uh oh!

jaimergp commented Nov 25, 2025

Uh oh!

jezdez commented Nov 25, 2025

Uh oh!

jaimergp commented Nov 25, 2025

Uh oh!

jaimergp commented Nov 25, 2025

Uh oh!

jaimergp commented Nov 25, 2025

Uh oh!

jezdez commented Dec 3, 2025

Uh oh!

jaimergp commented Dec 3, 2025

Uh oh!

jezdez left a comment

Choose a reason for hiding this comment

Uh oh!

jezdez Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

jaimergp Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

jezdez Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

jezdez commented Jan 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jaimergp commented Nov 20, 2025 •

edited

Loading