feat: warn on stale zst shards repodata#2153
Open
mohamedawnallah wants to merge 2 commits intoconda:mainfrom
Open
feat: warn on stale zst shards repodata#2153mohamedawnallah wants to merge 2 commits intoconda:mainfrom
mohamedawnallah wants to merge 2 commits intoconda:mainfrom
Conversation
Warn when stale `repodata.json.zst` or `repodata_shards.msgpack.zst` files exist but their outputs are disabled, preventing clients from silently consuming outdated package metadata.
Author
|
Hi @baszalmstra, @wolfv I am new to the Rattler codebase, and I am genuinely interested in contributing. I have submitted that PR to resolve this existing issue #1856. I have looked at the GitHub CI tests seems they are related to the changeset introduced in this PR #2132. Would love to receive any feedback. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we warn when stale
repodata.json.zstorrepodata_shards.msgpack.zstfiles exist, but their outputs are disabled, preventing clients from silently consuming outdated package metadata. It also adds integration tests to verify that it has the intended behavior changes and to ensure no regressions.Closes #1856.
Rattler Index Demo Update
before-stale-zst-shards-warning.mov
after-stale-zst-shards-warning.mov
How Has This Been Tested?
With integration tests in place in
tests/integration/stale_output_tests.rs.AI Disclosure
Tools: {Claude Code}
I used Claude Code to learn and explore relevant parts of rattler codebase. I also used it to write boilerpalate rust test code
Checklist: