fix(conda_types): parse features and license_family in MatchSpec#2175
Open
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Open
fix(conda_types): parse features and license_family in MatchSpec#2175ritankarsaha wants to merge 1 commit intoconda:mainfrom
ritankarsaha wants to merge 1 commit intoconda:mainfrom
Conversation
fix(conda_types): fixed ci fixed ci
862beb5 to
3af1376
Compare
Contributor
Author
|
@baszalmstra can you take a look into this ? Fixed all failing CIs properly |
baszalmstra
approved these changes
Mar 6, 2026
baszalmstra
requested changes
Mar 6, 2026
| // TODO: Still need to add `features` and `license_family` | ||
| // to the match spec. | ||
| "license_family" => match_spec.license_family = Some(value.to_string()), | ||
| "features" => match_spec.features = Some(value.to_string()), |
Collaborator
There was a problem hiding this comment.
Features have been deprecated and can be removed here.
| /// The license family of the package (e.g. `MIT`, `GPL`, `BSD`) | ||
| pub license_family: Option<String>, | ||
| /// The features of the package | ||
| pub features: Option<String>, |
Collaborator
There was a problem hiding this comment.
Features are not used anymore so this is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NamelessMatchSpec
arms
Fixes #2174
How Has This Been Tested?
Test plan
Checklist: