feat(py): add custom progress reporter callbacks to installer#2187
feat(py): add custom progress reporter callbacks to installer#2187ritankarsaha wants to merge 1 commit intoconda:mainfrom
Conversation
|
Did you meaure the performance overhead? |
Nope, didn't benchmark this. I think your concern is that I guess the straightforward mitigation would be to throttle What do you think @baszalmstra ? Is this approach correct? Should I add it here or do in a follow up PR or try something else? |
|
That is indeed my concern, but I might be wrong so first measuring the impact seems like the logical choice |
got it, on it |
Hello @baszalmstra - Here are the results:Phase A warm-cache (linking only)
Phase B cold-cache (download + linking)
Key observations:
According to me, the overhead is essentially zero for this package size. For very large packages that trigger hundreds or thousands of on_download_progress calls, it might be worth revisiting, but the current data shows no measurable GIL penalty. |
|
Can you try with a larger package? :D |
Ahh sure, trying it out !! |
Description
Fixes thr TODO - Accept functions to report progress in py-rattler/src/installer.rs.
Usage example
Fixes #2186
Checklist: