fix: add ptsname_r on Android compilation#2533
Merged
Merged
Conversation
The `rattler_pty` package is being used in `mise`, and in order to port it to Android/Termux it required a trivial patch to expose `ptsname_r` https://github.com/termux/termux-packages/blob/d4967a3307cc8386052ec3f395f9deef18f9544d/packages/mise/rattler_pty-android-target.diff This commit upstreams the patch to remove the need to vender/patch the dependency on Termux package respositories. This is Similar to conda#2524 Kudos for @igorgatis on the [discussion](jdx/mise#7026) for finding the patch.
baszalmstra
approved these changes
Jun 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
rattler_ptypackage is being used inmise, and in order to portit to Android/Termux it required a trivial patch to expose
ptsname_rhttps://github.com/termux/termux-packages/blob/d4967a3307cc8386052ec3f395f9deef18f9544d/packages/mise/rattler_pty-android-target.diff
This commit upstreams the patch to remove the need to vender/patch the
dependency on Termux package respositories.
This is Similar to #2524
Kudos for @igorgatis on the discussion for reporting the patch.
How Has This Been Tested?
Running with cross:
git clone github.com/conda/rattler.git cd crates/rattler_pty cross build --target aarch64-linux-androidChecklist: