Skip to content

feat: add boundary timer fields to WorkflowTask#1004

Draft
najeebkp wants to merge 1 commit into
conductor-oss:mainfrom
najeebkp:boundary-timer-fix
Draft

feat: add boundary timer fields to WorkflowTask#1004
najeebkp wants to merge 1 commit into
conductor-oss:mainfrom
najeebkp:boundary-timer-fix

Conversation

@najeebkp
Copy link
Copy Markdown
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

  • Add boundaryTimerDuration, boundaryTimerCompletionStatus, and boundaryTimerOutput as top-level fields on WorkflowTask so they are persisted as part of the workflow definition.

  • Fix UI (BoundaryTimerSection) to read/write these fields from the top-level task object instead of inputParameters.

Copy link
Copy Markdown
Collaborator

@v1r3n v1r3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets first review the approach before making code changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants