fix(e2e): scope FileStorageE2ETest to postgres + redis-es8#1388
Open
kowser-orkes wants to merge 1 commit into
Open
fix(e2e): scope FileStorageE2ETest to postgres + redis-es8#1388kowser-orkes wants to merge 1 commit into
kowser-orkes wants to merge 1 commit into
Conversation
- tag file-storage, excluded by default in e2e/build.gradle - postgres/es8 runner scripts opt in via -PrunFileStorageTests - postgres server config + compose bind mount enable file-storage locally, mirroring the existing es8 setup
kowser-orkes
force-pushed
the
fix/file-storage-e2e
branch
from
July 23, 2026 16:21
a4f0765 to
00de1d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
FileStorageE2ETestran on every e2e lane, but only redis-es8's config enablesconductor.file-storage.enabled→ 9 test failures (generic 404) on every other lane.@Tag("file-storage");e2e/build.gradleexcludes that tag by default.run_tests-postgres.shandrun_tests-es8.shopt back in via-PrunFileStorageTests; postgresalso gets file-storage enabled server-side (config properties + compose bind mount), mirroring
es8. No other lane's script changes — new default is "excluded."
Issue #
Alternatives considered
@EnabledIfSystemPropertygated by a flag derived from each lane's own config file — smallerdiff, no drift risk. Not used here per reviewer preference for tag+
excludeTags.