fix(status-notifier): use UTF-8 charset in webhook POST body - #1473
Open
shaileshpadave wants to merge 2 commits into
Open
fix(status-notifier): use UTF-8 charset in webhook POST body#1473shaileshpadave wants to merge 2 commits into
shaileshpadave wants to merge 2 commits into
Conversation
…-Length mismatch StringEntity(data) defaults to ISO-8859-1 on httpclient 4.5.x, causing the Content-Length to disagree with the actual UTF-8 body length for non-ASCII characters. Passing ContentType.APPLICATION_JSON ensures both the body bytes and Content-Length are computed as UTF-8. Fixes #1399
kowser-orkes
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
StringEntity(data)defaults to ISO-8859-1 on httpclient 4.5.x. This causesContent-Lengthto be computed from the ISO-8859-1 byte count, which disagrees with the actual UTF-8 body length whenever the payload contains a non-ASCII character (e.g. en dash–, non-breaking space). Strict HTTP receivers reject these POSTs.Fix: pass
ContentType.APPLICATION_JSON(UTF-8) toStringEntity.Fixes #1399
How to verify
Content-Length:{"note": "in–network"}(en dash U+2013).