-
Notifications
You must be signed in to change notification settings - Fork 755
fix: latter task cannot be executed because taskResult.getLogs() can return null and decide(workflowId) will not be invoked #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…return null and decide(workflowId) will not be invoked
|
@jmigueprieto could you please check this PR. The input logs of TaskResult can be null somehow and nullpointer exception throws. |
Hey @ColinZou - Thanks for bringing this up. I'll take a look. |
jmigueprieto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add a test or explain the execution path that leads to a NPE
- Change Optional usage.
core/src/main/java/com/netflix/conductor/core/execution/WorkflowExecutorOps.java
Outdated
Show resolved
Hide resolved
|
I found this NPE when invoking update task from rest API. The update task API accepts logs=null and the NPE get triggered in the place I fixed. |
Hi @ColinZou can you take care of the comments and we can merge. |
@v1r3n I am really not sure which comment left to be resolved. Let me know if I misunderstood anything either from you or @jmigueprieto please. |
…return null and decide(workflowId) will not be invoked
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Added null check for return value taskResult.getLogs before saving task execution log when update task.